404 page's stylesheet links are broken #1142
Labels
type:bug
A general bug
Comments
2 tasks
elliotgunton
added a commit
that referenced
this issue
Jul 31, 2024
…1143) **Pull Request Checklist** - [x] Fixes #1142 - ~~Tests added~~ no test needed - ~~Documentation/examples added~~ no additional documentation needed - [x] [Good commit messages](https://cbea.ms/git-commit/) and/or PR title **Description of PR** Currently, 404 page is not rendered properly because stylesheet links are broken in there. (details are described in the linked issue) This PR adds `site_url` attribute in `mkdocs.yml` for the workaround of #1142 . if css hash has changed, it can be broken again in 404 page of outdated docs. but with this workaround, at least latest docs will be rendered properly. --------- Signed-off-by: Ukjae Jeong <jeongukjae@gmail.com> Signed-off-by: Ukjae Jeong <JeongUkJae@gmail.com> Co-authored-by: Elliot Gunton <elliotgunton@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug report
Hera's document website is broken in 404 page. (i.e. https://hera.readthedocs.io/en/stable/123) The site should point css file in
https://hera.readthedocs.io/{lang}/{version}/assets/stylesheets/..., but 404 page pointshttps://hera.readthedocs.io/assets/stylesheets/{filename}.Screenshot:
Additional context
Related issues:
The text was updated successfully, but these errors were encountered: