Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update group publication list #313

Closed
wants to merge 1,024 commits into from
Closed

Conversation

osanstrong
Copy link
Contributor

Summary of changes

This PR updates the group publication list on the website with new publications, and adds pdf copies of several papers, reports, and proceedings for display.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Associated Issues and PRs

Associated Developers

Checklist for Reviewers

Reviewers should use this link to get to the
Review Checklist before they begin their review.

abachma2 and others added 30 commits April 23, 2021 09:38
Added ANS Student Conference Presentation
Added missing presentation image
…d a couple other small things, in the writing checklist
Andrei removed from People and added to Alumni
@abachma2
Copy link
Contributor

abachma2 commented Jul 9, 2024

Hi @osanstrong, thanks for working on this. It looks like a lot of new PDFs have been added to the repo. Are there that many new papers to add to the website? I just want to make sure that the repo and git log doesn't get cluttered with duplicate files.

Looking through the papers you added with my name, some of them are work that I did at a different institution before joining ARFC. I don't think those should be added to the website (the bachmann_empirical_2020, and bachmann_comparison_2021). I'm also not sure if @katyhuff wants to list theses on the website (I don't currently see them listed but that doesn't mean we can't start).

@osanstrong
Copy link
Contributor Author

Hi @abachma2, most of the new PDFs are PDF uploads of papers which were already listed but lacked a PDF copy; if updating files of already-listed publications is out of scope for this request, I can move it to its own PR.

As for the bachmann_empirical_2020 and bachmann_comparison_2021, if those were with a different institution that's a mistake on my end, and I will also check for/remove other additions which were published around the time of a member joining/leaving ARFC but do not clearly relate to the group.

@abachma2
Copy link
Contributor

abachma2 commented Jul 9, 2024

I think adding the PDFs is within the scope of this PR. I just wanted to make sure all of the files were necessary, because it's a lot. And yes, if you can take some time (I know it'll be a good bit of time) to double check that everything you've added pertains to ARFC, that would be great!

…t did not seem to partain to ARFC, and un-added respective PDF uploads
@osanstrong
Copy link
Contributor Author

I just unstaged a bunch which I had added because they were from around when a publisher was in the group, but in hindsight, did not seem related to the group.

I'll check again later, but that leaves substantially fewer publications to add.

@osanstrong osanstrong force-pushed the update-pubs branch 2 times, most recently from d71a8b6 to b1b52cd Compare July 10, 2024 15:51
@osanstrong
Copy link
Contributor Author

I was going through and deleting pdfs in a few batches from commit history, and despite best efforts, I think on the last batch I accidentally purged one that was already in the website somewhere (hence why a bunch of modifications of earlier commits suddenly popped up).

I think I'm going to manually rebase these additions in a new branch and PR that.

@abachma2
Copy link
Contributor

I would definitely see if you can sit down with someone in the group and go through what git commands you made, and figure out how to fix some of this. I know @katyhuff prefers to use merge instead of rebase in the group.

@osanstrong
Copy link
Contributor Author

Indeed; I spoke with Professor Huff this morning on the topic, and I realize I misspoke in that comment: I do not plan on using git rebase , rather, that I would manually make the same/net changes in a new branch, which I am about to submit a new PR for. (mentioning this PR and the original issue)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.