Fixing variable conflicts between Superset and Boot(swatch/strap) #8650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rusackas
changed the title
Codecov Report
@@ Coverage Diff @@
## master #8650 +/- ##
=======================================
Coverage 65.76% 65.76%
=======================================
Files 482 482
Lines 23824 23824
Branches 2594 2594
=======================================
Hits 15667 15667
Misses 7984 7984
Partials 173 173Continue to review full report at Codecov.
|
graceguo-supercat
approved these changes
Nov 26, 2019
dpgaspar
reviewed
Nov 27, 2019
| @gray: lighten(@gray-base, 33.5%); | ||
| @gray-light: lighten(@gray-base, 70%); | ||
| @bs-gray: lighten(@gray-base, 33.5%); | ||
| @bs-gray-light: lighten(@gray-base, 70%); |
There was a problem hiding this comment.
Yep, didn't worry about it since Prettier is about to wipe that out in @etr2460's next merge, and my next PR will rewrite or remove this file entirely ;)
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
There were a couple variable collisions between Superset's
variables.lessfile and the Bootswatch theme'svariables.less, both of which had an@grayvalue and@gray-light. I renamed the one ones the Bootstrap/Bootswatch side to have a@bs-...prefix to namespace them for now. Hopefully all is looking more like it ought to now.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
REVIEWERS
@graceguo-supercat