Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CSS] Font color contrast #8635

Closed
3 tasks done
graceguo-supercat opened this issue Nov 22, 2019 · 4 comments
Closed
3 tasks done

[CSS] Font color contrast #8635

graceguo-supercat opened this issue Nov 22, 2019 · 4 comments
Labels
enhancement:request Enhancement request submitted by anyone from the community

Comments

@graceguo-supercat
Copy link

I noticed there are some css and styling consolidation recently. It results some gray text become much lighter. See Run Query and other buttons:

Screenshots

Screen Shot 2019-11-22 at 12 52 20 PM

In the current font color standard, it's hard to tell the button is active or inactive state. And color contrast is not strong enough it makes me feel hard to read (but probably just me 😢

Environment

(please complete the following information):

  • superset version: superset version
  • python version: python --version
  • node.js version: node -v
  • npm version: npm -v

Checklist

Make sure these boxes are checked before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

Add any other context about the problem here.

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label #enhancement to this issue, with a confidence of 0.64. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@issue-label-bot issue-label-bot bot added the enhancement:request Enhancement request submitted by anyone from the community label Nov 22, 2019
@rusackas
Copy link
Member

Heya @graceguo-supercat :)

I'll make some touchups to address these issues. There were some cases where shades of gray were rounded to the nearest level a bit more harshly than others - I'll adjust the lighter bits of UI seen here.

We may find some additional elements that need tweaks, so please feel free to add to this PR or ping me on Superset Slack, and I'll tackle them as they come up.

@rusackas
Copy link
Member

@graceguo-supercat Just opened #8650 to address this.

@graceguo-supercat
Copy link
Author

Verified it is fixed in the latest build!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement:request Enhancement request submitted by anyone from the community
Projects
None yet
Development

No branches or pull requests

2 participants