Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetch charts with GET to benefit from browser cache and conditional requests #7032

Merged
merged 91 commits into from
Apr 3, 2019
Merged

Fetch charts with GET to benefit from browser cache and conditional requests #7032

merged 91 commits into from
Apr 3, 2019

Commits on Mar 5, 2019

  1. Sparkline dates aren't formatting in Time Series Table (apache#6976) 

    * Exclude venv for python linter to ignore

* Fix NaN error
    @khtruong @betodealmeida
    khtruong authored and betodealmeida committed Mar 5, 2019
    Configuration menu
    Copy the full SHA
    1ef7fb6 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2019

  1. Fix the white background shown in SQL editor on drag (apache#7021) 

    This PR sets the background-color css property on `.ace_scroller` instead of `.ace_content` to prevent the white background shown during resizing of the SQL editor before drag ends.
    @xtinec
    xtinec authored Mar 13, 2019
    Configuration menu
    Copy the full SHA
    e7d97db View commit details
    Browse the repository at this point in the history

  2. Show tooltip with time frame (apache#6979)

    @betodealmeida @xtinec
    betodealmeida authored and xtinec committed Mar 13, 2019
    Configuration menu
    Copy the full SHA
    e6886fb View commit details
    Browse the repository at this point in the history

  3. Fix time filter control (apache#6978)

    @betodealmeida @xtinec
    betodealmeida authored and xtinec committed Mar 13, 2019
    Configuration menu
    Copy the full SHA
    b3966e4 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2019

  1. Enhancement of query context and object. (apache#6962) 

    * added more functionalities for query context and object.

* fixed cache logic

* added default value for groupby

* updated comments and removed print

(cherry picked from commit d5b9795)
    @conglei @xtinec
    conglei authored and xtinec committed Mar 15, 2019
    Configuration menu
    Copy the full SHA
    f4e3923 View commit details
    Browse the repository at this point in the history

  2. [fix] /superset/slice/id url is too long (apache#6989) 

    (cherry picked from commit 6a4d507)
    @xtinec
    Grace Guo authored and xtinec committed Mar 15, 2019
    Configuration menu
    Copy the full SHA
    d7b2c3e View commit details
    Browse the repository at this point in the history

  3. [WIP] fix user specified JSON metadata not updating dashboard on refr… 

    …esh (apache#7027)

(cherry picked from commit cc58f0e)
    @thunter009 @xtinec
    thunter009 authored and xtinec committed Mar 15, 2019
    Configuration menu
    Copy the full SHA
    9855837 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2019

  1. feat: add ability to change font size in big number (apache#7003) 

    * Add ability to change font sizes in Big Number

* rename big number to header

* Add comment to clarify font size values
    @khtruong @kristw
    khtruong authored and kristw committed Mar 19, 2019
    Configuration menu
    Copy the full SHA
    6d0c390 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2019

  1. Allow LIMIT to be specified in parameters (apache#7052)

    @betodealmeida @xtinec
    betodealmeida authored and xtinec committed Mar 20, 2019
    Configuration menu
    Copy the full SHA
    0e1a3d3 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2019

  1. [fix] Cursor jumping when editing chart and dashboard titles (apache#… 

    …7038)

(cherry picked from commit fc1770f)
    @xtinec
    Grace Guo authored and xtinec committed Mar 21, 2019
    Configuration menu
    Copy the full SHA
    0c65b3f View commit details
    Browse the repository at this point in the history

  2. Changing time table viz to pass formatTime a date (apache#7020) 

    (cherry picked from commit 7f3c145)
    @michellethomas @xtinec
    michellethomas authored and xtinec committed Mar 21, 2019
    Configuration menu
    Copy the full SHA
    c65a166 View commit details
    Browse the repository at this point in the history

  3. [db-engine-spec] Aligning Hive/Presto partition logic (apache#7007) 

    (cherry picked from commit 05be866)
    @john-bodley @xtinec
    john-bodley authored and xtinec committed Mar 21, 2019
    Configuration menu
    Copy the full SHA
    771d212 View commit details
    Browse the repository at this point in the history

  4. [fix] explore chart from dashboard missed slice title (apache#7046) 

    (cherry picked from commit a6d48d4)
    @xtinec
    Grace Guo authored and xtinec committed Mar 21, 2019
    Configuration menu
    Copy the full SHA
    fa73a8d View commit details
    Browse the repository at this point in the history

  5. fix inaccurate data calculation with adata rolling and contribution (a… 

    …pache#7035)

(cherry picked from commit 0782e83)
    @conglei @xtinec
    conglei authored and xtinec committed Mar 21, 2019
    Configuration menu
    Copy the full SHA
    8d6e3f1 View commit details
    Browse the repository at this point in the history

  6. Adding warning message for sqllab save query (apache#7028) 

    (cherry picked from commit ead3d48)
    @michellethomas @xtinec
    michellethomas authored and xtinec committed Mar 21, 2019
    Configuration menu
    Copy the full SHA
    6d0752c View commit details
    Browse the repository at this point in the history

  7. [datasource] Ensuring consistent behavior of datasource editing/savin… 

    …g. (apache#7037)

* Update datasource.py

* Update datasource.py

(cherry picked from commit c771625)
    @john-bodley @xtinec
    john-bodley authored and xtinec committed Mar 21, 2019
    Configuration menu
    Copy the full SHA
    bd2a8b5 View commit details
    Browse the repository at this point in the history

  8. [csv-upload] Fixing message encoding (apache#6971) 

    (cherry picked from commit 48431ab)
    @john-bodley @xtinec
    john-bodley authored and xtinec committed Mar 21, 2019
    Configuration menu
    Copy the full SHA
    81a1287 View commit details
    Browse the repository at this point in the history

  9. [sql-parse] Fixing LIMIT exceptions (apache#6963) 

    (cherry picked from commit 3e076cb)
    @john-bodley @xtinec
    john-bodley authored and xtinec committed Mar 21, 2019
    Configuration menu
    Copy the full SHA
    6a7d5fc View commit details
    Browse the repository at this point in the history

  10. Adding custom control overrides (apache#6956) 

    * Adding extraOverrides to line chart

* Updating extraOverrides to fit with more cases

* Moving extraOverrides to index.js

* Removing webpack-merge in package.json

* Fixing metrics control clearing metric

(cherry picked from commit e619405)
    @michellethomas @xtinec
    michellethomas authored and xtinec committed Mar 21, 2019
    Configuration menu
    Copy the full SHA
    ee85089 View commit details
    Browse the repository at this point in the history

  11. [sqlparse] Fixing table name extraction for ill-defined query (apache… 

    …#7029)

(cherry picked from commit 07c340c)
    @john-bodley @xtinec
    john-bodley authored and xtinec committed Mar 21, 2019
    Configuration menu
    Copy the full SHA
    7bc3006 View commit details
    Browse the repository at this point in the history

  12. [missing values] Removing replacing missing values (apache#4905) 

    (cherry picked from commit 61add60)
    @john-bodley @xtinec
    john-bodley authored and xtinec committed Mar 21, 2019
    Configuration menu
    Copy the full SHA
    4ffc1b3 View commit details
    Browse the repository at this point in the history

  13. [SQL Lab] Improved query and results tabs rendering reliability (apac… 

    …he#7082)

closes apache#7080

(cherry picked from commit 9b58e9f)
    @enricoberti @xtinec
    enricoberti authored and xtinec committed Mar 21, 2019
    Configuration menu
    Copy the full SHA
    dfc0010 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2019

  1. Fix filter_box migration PR apache#6523 (apache#7066) 

    * Fix filter_box migration PR apache#6523

* Fix druid-related bug

(cherry picked from commit b210742)
    @mistercrunch @xtinec
    mistercrunch authored and xtinec committed Mar 25, 2019
    Configuration menu
    Copy the full SHA
    98cf417 View commit details
    Browse the repository at this point in the history

  2. SQL editor layout makeover (apache#7102) 

    This PR includes the following layout and css tweaks:
- Using flex to layout the north and south sub panes of query pane so resizing works properly in both Chrome and Firefox
- Removal of necessary wrapper divs and tweaking of css in sql lab so we can scroll to the bottom of both the table list and the results pane
- Make sql lab's content not overflow vertically and layout the query result area to eliminate double scroll bars
- css tweaks on the basic.html page so the loading animation appears in the center of the page across the board

(cherry picked from commit 71f1bbd)
    @xtinec
    xtinec committed Mar 25, 2019
    Configuration menu
    Copy the full SHA
    959199d View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2019

  1. [forms] Fix handling of NULLs 

    (cherry picked from commit e83a07d)
    @xtinec
    John Bodley authored and xtinec committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    b599855 View commit details
    Browse the repository at this point in the history

  2. handle null column_name in sqla and druid models 

    (cherry picked from commit 2ff721a)
    @xtinec
    Grace Guo authored and xtinec committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    9d21f70 View commit details
    Browse the repository at this point in the history

  3. Use metric name instead of metric in filter box (apache#7106) 

    (cherry picked from commit 003364e)
    @michellethomas @xtinec
    michellethomas authored and xtinec committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    bdbb354 View commit details
    Browse the repository at this point in the history

  4. Bump python lib croniter to an existing version (apache#7132) 

    Package maintainers should really never delete packages, but it appears
this happened with croniter and resulted in breaking our builds.

This PR bumps to a more recent existing version of the library

(cherry picked from commit 215ed39)
    @mistercrunch @xtinec
    mistercrunch authored and xtinec committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    87fb2df View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2019

  1. Revert PR apache#6933 (apache#7162)

    @betodealmeida
    betodealmeida authored Mar 28, 2019
    Configuration menu
    Copy the full SHA
    b7fb15f View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2019

  1. Add decorator for etag cache

    @betodealmeida
    betodealmeida committed Mar 29, 2019
    Configuration menu
    Copy the full SHA
    63f98dc View commit details
    Browse the repository at this point in the history

  2. Fetch charts with GET

    @betodealmeida
    betodealmeida committed Mar 29, 2019
    Configuration menu
    Copy the full SHA
    b65dca6 View commit details
    Browse the repository at this point in the history

  3. Small fixes

    @betodealmeida
    betodealmeida committed Mar 29, 2019
    Configuration menu
    Copy the full SHA
    a70a2f4 View commit details
    Browse the repository at this point in the history

  4. Fix typo

    @betodealmeida
    betodealmeida committed Mar 29, 2019
    Configuration menu
    Copy the full SHA
    afabd44 View commit details
    Browse the repository at this point in the history

  5. Compute correct cache key; fix logging

    @betodealmeida
    betodealmeida committed Mar 29, 2019
    Configuration menu
    Copy the full SHA
    c49dc70 View commit details
    Browse the repository at this point in the history

  6. Check perms on cached response

    @betodealmeida
    betodealmeida committed Mar 29, 2019
    Configuration menu
    Copy the full SHA
    ac07631 View commit details
    Browse the repository at this point in the history

  7. Revert change

    @betodealmeida
    betodealmeida committed Mar 29, 2019
    Configuration menu
    Copy the full SHA
    ea26a75 View commit details
    Browse the repository at this point in the history

  8. If perms fail, return naked response

    @betodealmeida
    betodealmeida committed Mar 29, 2019
    Configuration menu
    Copy the full SHA
    9d4acf7 View commit details
    Browse the repository at this point in the history

  9. Fix lint

    @betodealmeida
    betodealmeida committed Mar 29, 2019
    Configuration menu
    Copy the full SHA
    2a46132 View commit details
    Browse the repository at this point in the history

  10. Compute cache key from all form data

    @betodealmeida
    betodealmeida committed Mar 29, 2019
    Configuration menu
    Copy the full SHA
    c65a0dd View commit details
    Browse the repository at this point in the history

  11. Pass extra_filters in GET request

    @betodealmeida
    betodealmeida committed Mar 29, 2019
    Configuration menu
    Copy the full SHA
    35a7868 View commit details
    Browse the repository at this point in the history

  12. Fix pylint

    @betodealmeida
    betodealmeida committed Mar 29, 2019
    Configuration menu
    Copy the full SHA
    4dd19e0 View commit details
    Browse the repository at this point in the history

  13. Fix flake8

    @betodealmeida
    betodealmeida committed Mar 29, 2019
    Configuration menu
    Copy the full SHA
    debd5e0 View commit details
    Browse the repository at this point in the history

  14. Use ETags even if no cache is set

    @betodealmeida
    betodealmeida committed Mar 29, 2019
    Configuration menu
    Copy the full SHA
    e49cd03 View commit details
    Browse the repository at this point in the history

  15. Handle adhoc filters

    @betodealmeida
    betodealmeida committed Mar 29, 2019
    Configuration menu
    Copy the full SHA
    ca65c0c View commit details
    Browse the repository at this point in the history

  16. Raise in debug mode

    @betodealmeida
    betodealmeida committed Mar 29, 2019
    Configuration menu
    Copy the full SHA
    58c84db View commit details
    Browse the repository at this point in the history

  17. Rename actions

    @betodealmeida
    betodealmeida committed Mar 29, 2019
    Configuration menu
    Copy the full SHA
    60e849b View commit details
    Browse the repository at this point in the history

  18. Fix integration tests

    @betodealmeida
    betodealmeida committed Mar 29, 2019
    Configuration menu
    Copy the full SHA
    a913a84 View commit details
    Browse the repository at this point in the history

  19. Do POST request on new charts

    @betodealmeida
    betodealmeida committed Mar 29, 2019
    Configuration menu
    Copy the full SHA
    8ed131d View commit details
    Browse the repository at this point in the history

  20. Set extra/adhoc filters only in GET requests

    @betodealmeida
    betodealmeida committed Mar 29, 2019
    Configuration menu
    Copy the full SHA
    e96784a View commit details
    Browse the repository at this point in the history

  21. Raise if check_perms fails

    @betodealmeida
    betodealmeida committed Mar 29, 2019
    Configuration menu
    Copy the full SHA
    3f49312 View commit details
    Browse the repository at this point in the history

  22. Refactor auth

    @betodealmeida
    betodealmeida committed Mar 29, 2019
    Configuration menu
    Copy the full SHA
    532dc2e View commit details
    Browse the repository at this point in the history

  23. Fix flake8

    @betodealmeida
    betodealmeida committed Mar 29, 2019
    Configuration menu
    Copy the full SHA
    2631325 View commit details
    Browse the repository at this point in the history

  24. Fix js unit tests

    @betodealmeida
    betodealmeida committed Mar 29, 2019
    Configuration menu
    Copy the full SHA
    7fb1931 View commit details
    Browse the repository at this point in the history

  25. Fix js unit tests that fail in lyftga

    @betodealmeida
    betodealmeida committed Mar 29, 2019
    Configuration menu
    Copy the full SHA
    cc15133 View commit details
    Browse the repository at this point in the history

  26. Fix js

    @betodealmeida
    betodealmeida committed Mar 29, 2019
    Configuration menu
    Copy the full SHA
    cb1e7cb View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2019

  1. Sparkline dates aren't formatting in Time Series Table (apache#6976) 

    * Exclude venv for python linter to ignore

* Fix NaN error
    @khtruong @betodealmeida
    khtruong authored and betodealmeida committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    2f97bf9 View commit details
    Browse the repository at this point in the history

  2. Changing time table viz to pass formatTime a date (apache#7020) 

    (cherry picked from commit 7f3c145)
    @michellethomas @betodealmeida
    michellethomas authored and betodealmeida committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    32088cc View commit details
    Browse the repository at this point in the history

  3. SQL editor layout makeover (apache#7102) 

    This PR includes the following layout and css tweaks:
- Using flex to layout the north and south sub panes of query pane so resizing works properly in both Chrome and Firefox
- Removal of necessary wrapper divs and tweaking of css in sql lab so we can scroll to the bottom of both the table list and the results pane
- Make sql lab's content not overflow vertically and layout the query result area to eliminate double scroll bars
- css tweaks on the basic.html page so the loading animation appears in the center of the page across the board

(cherry picked from commit 71f1bbd)
    @xtinec @betodealmeida
    xtinec authored and betodealmeida committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    23dadc7 View commit details
    Browse the repository at this point in the history

  4. Add decorator for etag cache

    @betodealmeida
    betodealmeida committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    dc59507 View commit details
    Browse the repository at this point in the history

  5. Fetch charts with GET

    @betodealmeida
    betodealmeida committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    a745f32 View commit details
    Browse the repository at this point in the history

  6. Small fixes

    @betodealmeida
    betodealmeida committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    1931441 View commit details
    Browse the repository at this point in the history

  7. Fix typo

    @betodealmeida
    betodealmeida committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    ff037e5 View commit details
    Browse the repository at this point in the history

  8. Compute correct cache key; fix logging

    @betodealmeida
    betodealmeida committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    6a4adb3 View commit details
    Browse the repository at this point in the history

  9. Check perms on cached response

    @betodealmeida
    betodealmeida committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    9436034 View commit details
    Browse the repository at this point in the history

  10. Revert change

    @betodealmeida
    betodealmeida committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    9df4dc2 View commit details
    Browse the repository at this point in the history

  11. If perms fail, return naked response

    @betodealmeida
    betodealmeida committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    e0fbb64 View commit details
    Browse the repository at this point in the history

  12. Fix lint

    @betodealmeida
    betodealmeida committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    c093b03 View commit details
    Browse the repository at this point in the history

  13. Compute cache key from all form data

    @betodealmeida
    betodealmeida committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    ef3afd2 View commit details
    Browse the repository at this point in the history

  14. Pass extra_filters in GET request

    @betodealmeida
    betodealmeida committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    86e4b93 View commit details
    Browse the repository at this point in the history

  15. Fix pylint

    @betodealmeida
    betodealmeida committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    68412bf View commit details
    Browse the repository at this point in the history

  16. Fix flake8

    @betodealmeida
    betodealmeida committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    69eeb1d View commit details
    Browse the repository at this point in the history

  17. Use ETags even if no cache is set

    @betodealmeida
    betodealmeida committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    fe8cc65 View commit details
    Browse the repository at this point in the history

  18. Handle adhoc filters

    @betodealmeida
    betodealmeida committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    f8200a1 View commit details
    Browse the repository at this point in the history

  19. Raise in debug mode

    @betodealmeida
    betodealmeida committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    b3c488d View commit details
    Browse the repository at this point in the history

  20. Rename actions

    @betodealmeida
    betodealmeida committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    89f0192 View commit details
    Browse the repository at this point in the history

  21. Fix integration tests

    @betodealmeida
    betodealmeida committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    3324f15 View commit details
    Browse the repository at this point in the history

  22. Do POST request on new charts

    @betodealmeida
    betodealmeida committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    c0caac8 View commit details
    Browse the repository at this point in the history

  23. Set extra/adhoc filters only in GET requests

    @betodealmeida
    betodealmeida committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    4b9ffa7 View commit details
    Browse the repository at this point in the history

  24. Raise if check_perms fails

    @betodealmeida
    betodealmeida committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    b75e11e View commit details
    Browse the repository at this point in the history

  25. Refactor auth

    @betodealmeida
    betodealmeida committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    96e3c9b View commit details
    Browse the repository at this point in the history

  26. Fix flake8

    @betodealmeida
    betodealmeida committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    a1fdb44 View commit details
    Browse the repository at this point in the history

  27. Fix js unit tests

    @betodealmeida
    betodealmeida committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    d0bff86 View commit details
    Browse the repository at this point in the history

  28. Fix js unit tests that fail in lyftga

    @betodealmeida
    betodealmeida committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    057b953 View commit details
    Browse the repository at this point in the history

  29. Fix js

    @betodealmeida
    betodealmeida committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    7da0157 View commit details
    Browse the repository at this point in the history

  30. Merge

    @betodealmeida
    betodealmeida committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    ce17182 View commit details
    Browse the repository at this point in the history

  31. Fix bad merge

    @betodealmeida
    betodealmeida committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    a364194 View commit details
    Browse the repository at this point in the history

  32. Use far future when max_age=0

    @betodealmeida
    betodealmeida committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    5e418ed View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2019

  1. Merge

    @betodealmeida
    betodealmeida committed Apr 3, 2019
    Configuration menu
    Copy the full SHA
    407a87f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'lyft-VIZ-334' into VIZ-334

    @betodealmeida
    betodealmeida committed Apr 3, 2019
    Configuration menu
    Copy the full SHA
    b48c57e View commit details
    Browse the repository at this point in the history

  3. Fix conflict

    @betodealmeida
    betodealmeida committed Apr 3, 2019
    Configuration menu
    Copy the full SHA
    cb8cc64 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'lyft-VIZ-334' into VIZ-334

    @betodealmeida
    betodealmeida committed Apr 3, 2019
    Configuration menu
    Copy the full SHA
    67e5980 View commit details
    Browse the repository at this point in the history