Improving Filter Box #6523

mistercrunch · 2018-12-12T16:39:40Z

There's a longer term plan to improve filters, but this PR is aiming at adding a few well-needed options to the old "Filter Box". I figured the FilterCollectionControl can be reused in the future.

related to #5925, #5269, #3272, #2367

TODO:

unit test for FilterBoxItemControl
unit test for FormRow
parallelize server side?

mistercrunch · 2018-12-12T16:42:48Z

superset/assets/src/chart/ChartRenderer.jsx

@@ -38,7 +38,7 @@ const defaultProps = {
  triggerRender: false,
 };

-class ChartRenderer extends React.PureComponent {
+class ChartRenderer extends React.Component {


Unrelated change, caught some React related warning

codecov-io · 2018-12-12T18:02:25Z

Codecov Report

Merging #6523 into master will increase coverage by 0.01%.
The diff coverage is 54.83%.

@@            Coverage Diff             @@
##           master    #6523      +/-   ##
==========================================
+ Coverage   56.25%   56.26%   +0.01%     
==========================================
  Files         518      519       +1     
  Lines       23006    23069      +63     
  Branches     2750     2756       +6     
==========================================
+ Hits        12941    12979      +38     
- Misses       9654     9680      +26     
+ Partials      411      410       -1

Impacted Files	Coverage Δ
...et/assets/src/explore/components/controls/index.js	`100% <ø> (ø)`	⬆️
superset/assets/src/chart/ChartRenderer.jsx	`8.47% <ø> (ø)`	⬆️
superset/data/world_bank.py	`100% <ø> (ø)`	⬆️
.../explore/components/controls/CollectionControl.jsx	`22.58% <ø> (ø)`	⬆️
...ets/src/visualizations/FilterBox/transformProps.js	`0% <0%> (ø)`	⬆️
superset/assets/src/explore/controls.jsx	`42.74% <0%> (-0.35%)`	⬇️
.../assets/src/visualizations/FilterBox/FilterBox.jsx	`0% <0%> (ø)`	⬆️
...plore/components/controls/FilterBoxItemControl.jsx	`62.85% <62.85%> (ø)`
superset/viz.py	`72.24% <85%> (-0.03%)`	⬇️
superset/assets/src/components/FormRow.jsx	`92.3% <92.3%> (ø)`
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbf9586...88c6223. Read the comment docs.

vylc · 2018-12-21T22:48:18Z

Tweaked the verbiage for some of these options

mistercrunch · 2018-12-21T23:44:14Z

Another idea I had was to support multi-columns eventually. That'd be how we'd support "cascading dropdowns" , powered by a single query.

mistercrunch · 2018-12-22T00:00:56Z

@vylc what's the Global option?

mistercrunch · 2018-12-28T18:10:17Z

mistercrunch · 2019-01-10T01:14:29Z

Hey I think I'd like to checkpoint the work on filters here. We can improve things further in a future PR but this is already a fairly large PR, and closes many features request as is.

betodealmeida · 2019-01-11T23:24:59Z

This looks awesome! Taking a last look, sorry for the delay.

kaitorecca · 2019-01-23T05:13:07Z

How it handle to make filter impact on other chart component on the same default when default value is set? Per my understanding from code, once you set value, it just show there, not effect other chart because only onchange event was there

mistercrunch · 2019-01-24T05:06:05Z

good catch @kaitorecca, opened an issue here: #6746

* Improve Filter Box * layout tweaks (cherry picked from commit 7e0e7c8)

michellethomas · 2019-03-19T22:01:27Z

superset/migrations/versions/fb13d49b72f9_better_filters.py

+            params = json.loads(slc.params)
+            logging.info(f'Upgrading {slc.slice_name}')
+            cols = params.get('groupby')
+            metrics = params.get('metrics')


@mistercrunch it looks like the param for filter_box was metric so this isn't migrating any of the filter box metrics correctly, they are getting set to null cc: @graceguo-supercat

You're right, and I'm confused as to how this got through... Let me send a fix now

michellethomas · 2019-03-19T22:06:58Z

@mistercrunch another issue, the new filters break with filter charts on druid datasources if you don't select a metric in your filter. Metric is now not a required field, and it seems sqla datasources don't require you to have a metric, but filter boxes on druid datasource will break without a metric with list index out of range

File "superset/connectors/druid/models.py", line 1150, in run_query
    order_by = list(qry['aggregations'].keys())[0]
IndexError: list index out of range

Because the metric field wasn't migrated and is null, existing filter boxes on druid datasources are broken. Can we also add tests for this case?
cc @graceguo-supercat

mistercrunch · 2019-03-19T23:19:53Z

👀

mistercrunch · 2019-03-20T00:41:56Z

@michellethomas thanks for reporting this, issue, I submitted a fix here #7066

* Fix filter_box migration PR #6523 * Fix druid-related bug

* Fix filter_box migration PR #6523 * Fix druid-related bug (cherry picked from commit b210742)

* Sparkline dates aren't formatting in Time Series Table (#6976) * Exclude venv for python linter to ignore * Fix NaN error * Fix the white background shown in SQL editor on drag (#7021) This PR sets the background-color css property on `.ace_scroller` instead of `.ace_content` to prevent the white background shown during resizing of the SQL editor before drag ends. * Show tooltip with time frame (#6979) * Fix time filter control (#6978) * Enhancement of query context and object. (#6962) * added more functionalities for query context and object. * fixed cache logic * added default value for groupby * updated comments and removed print (cherry picked from commit d5b9795) * [fix] /superset/slice/id url is too long (#6989) (cherry picked from commit 6a4d507) * [WIP] fix user specified JSON metadata not updating dashboard on refresh (#7027) (cherry picked from commit cc58f0e) * feat: add ability to change font size in big number (#7003) * Add ability to change font sizes in Big Number * rename big number to header * Add comment to clarify font size values * Allow LIMIT to be specified in parameters (#7052) * [fix] Cursor jumping when editing chart and dashboard titles (#7038) (cherry picked from commit fc1770f) * Changing time table viz to pass formatTime a date (#7020) (cherry picked from commit 7f3c145) * [db-engine-spec] Aligning Hive/Presto partition logic (#7007) (cherry picked from commit 05be866) * [fix] explore chart from dashboard missed slice title (#7046) (cherry picked from commit a6d48d4) * fix inaccurate data calculation with adata rolling and contribution (#7035) (cherry picked from commit 0782e83) * Adding warning message for sqllab save query (#7028) (cherry picked from commit ead3d48) * [datasource] Ensuring consistent behavior of datasource editing/saving. (#7037) * Update datasource.py * Update datasource.py (cherry picked from commit c771625) * [csv-upload] Fixing message encoding (#6971) (cherry picked from commit 48431ab) * [sql-parse] Fixing LIMIT exceptions (#6963) (cherry picked from commit 3e076cb) * Adding custom control overrides (#6956) * Adding extraOverrides to line chart * Updating extraOverrides to fit with more cases * Moving extraOverrides to index.js * Removing webpack-merge in package.json * Fixing metrics control clearing metric (cherry picked from commit e619405) * [sqlparse] Fixing table name extraction for ill-defined query (#7029) (cherry picked from commit 07c340c) * [missing values] Removing replacing missing values (#4905) (cherry picked from commit 61add60) * [SQL Lab] Improved query and results tabs rendering reliability (#7082) closes #7080 (cherry picked from commit 9b58e9f) * Fix filter_box migration PR #6523 (#7066) * Fix filter_box migration PR #6523 * Fix druid-related bug (cherry picked from commit b210742) * SQL editor layout makeover (#7102) This PR includes the following layout and css tweaks: - Using flex to layout the north and south sub panes of query pane so resizing works properly in both Chrome and Firefox - Removal of necessary wrapper divs and tweaking of css in sql lab so we can scroll to the bottom of both the table list and the results pane - Make sql lab's content not overflow vertically and layout the query result area to eliminate double scroll bars - css tweaks on the basic.html page so the loading animation appears in the center of the page across the board (cherry picked from commit 71f1bbd) * [forms] Fix handling of NULLs (cherry picked from commit e83a07d) * handle null column_name in sqla and druid models (cherry picked from commit 2ff721a) * Use metric name instead of metric in filter box (#7106) (cherry picked from commit 003364e) * Bump python lib croniter to an existing version (#7132) Package maintainers should really never delete packages, but it appears this happened with croniter and resulted in breaking our builds. This PR bumps to a more recent existing version of the library (cherry picked from commit 215ed39) * Revert PR #6933 (#7162) * [bugfix] SQL Lab 'Filter Results' doesn't stick (#7104) When using a "Search Results" criteria, the subset of rows that match the criteria get displayed. While this the filter is applied, if another query is run, the filter is still active, but not displayed in the input text box. After this change, the state of the input box sticks after subsequent queries. (cherry picked from commit d5e8d66) * Injectable statsd client (#7138) * Add ability to inject statsd client; some py test/reqs updates - Updated the metrics logger to allow construction with an existing statsd client, so that it can be configured by external systems or libs. - added requirements to requirements-dev.txt which are needed to run tests-eg coverage, nose - removed dependency on mock lib, it is in python stdlib now - updated tox.ini to remove the now-superfluous deps * add license to test file, and remove blank line at EOF (cherry picked from commit ba19a62) * [Lyft-GA] Enable color consistency in a dashboard (#7135) * Enable color consistency in a dashboard Moved actions, minor UI, allowed dashboard copy Fix linting errors Undo unintentional change Updated and added unit tests Fail quietly if package has not been updated Fail quietly on dashboard copy if package is old * Update packages * Remove unnecessary code * Addressed Grace's comments * Small fix for item key * Reset chart's color during exploration * Do not reset chart form data when exploring chart * Fix double scroll bars when content of sql result table overflows horizontally (#7168) The PR substracts the scrollbar height from the height of the container of the react virtualized table so we don't see double scrollbars. (cherry picked from commit 7ffcabd) * Change number format default * Use smart formatter instead * fix merge issues * Use SMART_NUMBER

…equests (#7032) * Sparkline dates aren't formatting in Time Series Table (#6976) * Exclude venv for python linter to ignore * Fix NaN error * Fix the white background shown in SQL editor on drag (#7021) This PR sets the background-color css property on `.ace_scroller` instead of `.ace_content` to prevent the white background shown during resizing of the SQL editor before drag ends. * Show tooltip with time frame (#6979) * Fix time filter control (#6978) * Enhancement of query context and object. (#6962) * added more functionalities for query context and object. * fixed cache logic * added default value for groupby * updated comments and removed print (cherry picked from commit d5b9795) * [fix] /superset/slice/id url is too long (#6989) (cherry picked from commit 6a4d507) * [WIP] fix user specified JSON metadata not updating dashboard on refresh (#7027) (cherry picked from commit cc58f0e) * feat: add ability to change font size in big number (#7003) * Add ability to change font sizes in Big Number * rename big number to header * Add comment to clarify font size values * Allow LIMIT to be specified in parameters (#7052) * [fix] Cursor jumping when editing chart and dashboard titles (#7038) (cherry picked from commit fc1770f) * Changing time table viz to pass formatTime a date (#7020) (cherry picked from commit 7f3c145) * [db-engine-spec] Aligning Hive/Presto partition logic (#7007) (cherry picked from commit 05be866) * [fix] explore chart from dashboard missed slice title (#7046) (cherry picked from commit a6d48d4) * fix inaccurate data calculation with adata rolling and contribution (#7035) (cherry picked from commit 0782e83) * Adding warning message for sqllab save query (#7028) (cherry picked from commit ead3d48) * [datasource] Ensuring consistent behavior of datasource editing/saving. (#7037) * Update datasource.py * Update datasource.py (cherry picked from commit c771625) * [csv-upload] Fixing message encoding (#6971) (cherry picked from commit 48431ab) * [sql-parse] Fixing LIMIT exceptions (#6963) (cherry picked from commit 3e076cb) * Adding custom control overrides (#6956) * Adding extraOverrides to line chart * Updating extraOverrides to fit with more cases * Moving extraOverrides to index.js * Removing webpack-merge in package.json * Fixing metrics control clearing metric (cherry picked from commit e619405) * [sqlparse] Fixing table name extraction for ill-defined query (#7029) (cherry picked from commit 07c340c) * [missing values] Removing replacing missing values (#4905) (cherry picked from commit 61add60) * [SQL Lab] Improved query and results tabs rendering reliability (#7082) closes #7080 (cherry picked from commit 9b58e9f) * Fix filter_box migration PR #6523 (#7066) * Fix filter_box migration PR #6523 * Fix druid-related bug (cherry picked from commit b210742) * SQL editor layout makeover (#7102) This PR includes the following layout and css tweaks: - Using flex to layout the north and south sub panes of query pane so resizing works properly in both Chrome and Firefox - Removal of necessary wrapper divs and tweaking of css in sql lab so we can scroll to the bottom of both the table list and the results pane - Make sql lab's content not overflow vertically and layout the query result area to eliminate double scroll bars - css tweaks on the basic.html page so the loading animation appears in the center of the page across the board (cherry picked from commit 71f1bbd) * [forms] Fix handling of NULLs (cherry picked from commit e83a07d) * handle null column_name in sqla and druid models (cherry picked from commit 2ff721a) * Use metric name instead of metric in filter box (#7106) (cherry picked from commit 003364e) * Bump python lib croniter to an existing version (#7132) Package maintainers should really never delete packages, but it appears this happened with croniter and resulted in breaking our builds. This PR bumps to a more recent existing version of the library (cherry picked from commit 215ed39) * Revert PR #6933 (#7162) * Add decorator for etag cache * Fetch charts with GET * Small fixes * Fix typo * Compute correct cache key; fix logging * Check perms on cached response * Revert change * If perms fail, return naked response * Fix lint * Compute cache key from all form data * Pass extra_filters in GET request * Fix pylint * Fix flake8 * Use ETags even if no cache is set * Handle adhoc filters * Raise in debug mode * Rename actions * Fix integration tests * Do POST request on new charts * Set extra/adhoc filters only in GET requests * Raise if check_perms fails * Refactor auth * Fix flake8 * Fix js unit tests * Fix js unit tests that fail in lyftga * Fix js * Sparkline dates aren't formatting in Time Series Table (#6976) * Exclude venv for python linter to ignore * Fix NaN error * Changing time table viz to pass formatTime a date (#7020) (cherry picked from commit 7f3c145) * SQL editor layout makeover (#7102) This PR includes the following layout and css tweaks: - Using flex to layout the north and south sub panes of query pane so resizing works properly in both Chrome and Firefox - Removal of necessary wrapper divs and tweaking of css in sql lab so we can scroll to the bottom of both the table list and the results pane - Make sql lab's content not overflow vertically and layout the query result area to eliminate double scroll bars - css tweaks on the basic.html page so the loading animation appears in the center of the page across the board (cherry picked from commit 71f1bbd) * Add decorator for etag cache * Fetch charts with GET * Small fixes * Fix typo * Compute correct cache key; fix logging * Check perms on cached response * Revert change * If perms fail, return naked response * Fix lint * Compute cache key from all form data * Pass extra_filters in GET request * Fix pylint * Fix flake8 * Use ETags even if no cache is set * Handle adhoc filters * Raise in debug mode * Rename actions * Fix integration tests * Do POST request on new charts * Set extra/adhoc filters only in GET requests * Raise if check_perms fails * Refactor auth * Fix flake8 * Fix js unit tests * Fix js unit tests that fail in lyftga * Fix js * Fix bad merge * Use far future when max_age=0

* Sparkline dates aren't formatting in Time Series Table (#6976) * Exclude venv for python linter to ignore * Fix NaN error * Fix the white background shown in SQL editor on drag (#7021) This PR sets the background-color css property on `.ace_scroller` instead of `.ace_content` to prevent the white background shown during resizing of the SQL editor before drag ends. * Show tooltip with time frame (#6979) * Fix time filter control (#6978) * Enhancement of query context and object. (#6962) * added more functionalities for query context and object. * fixed cache logic * added default value for groupby * updated comments and removed print (cherry picked from commit d5b9795) * [fix] /superset/slice/id url is too long (#6989) (cherry picked from commit 6a4d507) * [WIP] fix user specified JSON metadata not updating dashboard on refresh (#7027) (cherry picked from commit cc58f0e) * feat: add ability to change font size in big number (#7003) * Add ability to change font sizes in Big Number * rename big number to header * Add comment to clarify font size values * Allow LIMIT to be specified in parameters (#7052) * [fix] Cursor jumping when editing chart and dashboard titles (#7038) (cherry picked from commit fc1770f) * Changing time table viz to pass formatTime a date (#7020) (cherry picked from commit 7f3c145) * [db-engine-spec] Aligning Hive/Presto partition logic (#7007) (cherry picked from commit 05be866) * [fix] explore chart from dashboard missed slice title (#7046) (cherry picked from commit a6d48d4) * fix inaccurate data calculation with adata rolling and contribution (#7035) (cherry picked from commit 0782e83) * Adding warning message for sqllab save query (#7028) (cherry picked from commit ead3d48) * [datasource] Ensuring consistent behavior of datasource editing/saving. (#7037) * Update datasource.py * Update datasource.py (cherry picked from commit c771625) * [csv-upload] Fixing message encoding (#6971) (cherry picked from commit 48431ab) * [sql-parse] Fixing LIMIT exceptions (#6963) (cherry picked from commit 3e076cb) * Adding custom control overrides (#6956) * Adding extraOverrides to line chart * Updating extraOverrides to fit with more cases * Moving extraOverrides to index.js * Removing webpack-merge in package.json * Fixing metrics control clearing metric (cherry picked from commit e619405) * [sqlparse] Fixing table name extraction for ill-defined query (#7029) (cherry picked from commit 07c340c) * [missing values] Removing replacing missing values (#4905) (cherry picked from commit 61add60) * [SQL Lab] Improved query and results tabs rendering reliability (#7082) closes #7080 (cherry picked from commit 9b58e9f) * Fix filter_box migration PR #6523 (#7066) * Fix filter_box migration PR #6523 * Fix druid-related bug (cherry picked from commit b210742) * SQL editor layout makeover (#7102) This PR includes the following layout and css tweaks: - Using flex to layout the north and south sub panes of query pane so resizing works properly in both Chrome and Firefox - Removal of necessary wrapper divs and tweaking of css in sql lab so we can scroll to the bottom of both the table list and the results pane - Make sql lab's content not overflow vertically and layout the query result area to eliminate double scroll bars - css tweaks on the basic.html page so the loading animation appears in the center of the page across the board (cherry picked from commit 71f1bbd) * [forms] Fix handling of NULLs (cherry picked from commit e83a07d) * handle null column_name in sqla and druid models (cherry picked from commit 2ff721a) * Use metric name instead of metric in filter box (#7106) (cherry picked from commit 003364e) * Bump python lib croniter to an existing version (#7132) Package maintainers should really never delete packages, but it appears this happened with croniter and resulted in breaking our builds. This PR bumps to a more recent existing version of the library (cherry picked from commit 215ed39) * Revert PR #6933 (#7162) * Celery worker for warming up cache * Remove testing changes * Add documentation * Fix lint * WIP dashboard filters * Use new cache so it works with dashboards * Add more unit tests, fix old ones * Fix flake8 and docs * Sparkline dates aren't formatting in Time Series Table (#6976) * Exclude venv for python linter to ignore * Fix NaN error * Changing time table viz to pass formatTime a date (#7020) (cherry picked from commit 7f3c145) * SQL editor layout makeover (#7102) This PR includes the following layout and css tweaks: - Using flex to layout the north and south sub panes of query pane so resizing works properly in both Chrome and Firefox - Removal of necessary wrapper divs and tweaking of css in sql lab so we can scroll to the bottom of both the table list and the results pane - Make sql lab's content not overflow vertically and layout the query result area to eliminate double scroll bars - css tweaks on the basic.html page so the loading animation appears in the center of the page across the board (cherry picked from commit 71f1bbd) * Celery worker for warming up cache * Remove testing changes * Add documentation * Fix lint * WIP dashboard filters * Use new cache so it works with dashboards * Add more unit tests, fix old ones * Fix flake8 and docs * Fix bad merge and pylint

mistercrunch commented Dec 12, 2018

View reviewed changes

mistercrunch added risk:db-migration PRs that require a DB migration enhancement:request Enhancement request submitted by anyone from the community labels Dec 12, 2018

mistercrunch force-pushed the better_filters branch from 73f1efc to d0b3fe2 Compare December 21, 2018 19:29

mistercrunch changed the title ~~[WiP] improving Filter Box~~ Improving Filter Box Dec 21, 2018

mistercrunch force-pushed the better_filters branch from d0b3fe2 to 1866bc0 Compare December 21, 2018 20:37

mistercrunch mentioned this pull request Dec 25, 2018

[filter box] sort values in the filter #2367

Closed

mistercrunch force-pushed the better_filters branch from 1866bc0 to 3f64dac Compare December 28, 2018 18:09

mistercrunch force-pushed the better_filters branch from 3f64dac to 98422ac Compare December 28, 2018 18:23

mistercrunch requested a review from betodealmeida January 4, 2019 17:11

mistercrunch added 2 commits January 9, 2019 16:19

Improve Filter Box

21c9cc8

layout tweaks

88c6223

mistercrunch force-pushed the better_filters branch from 98422ac to 88c6223 Compare January 10, 2019 00:20

betodealmeida merged commit 7e0e7c8 into apache:master Jan 11, 2019

mistercrunch added the risk:many-files Change has too many files label Jan 12, 2019

mistercrunch deleted the better_filters branch January 24, 2019 05:03

betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Jan 31, 2019

Improving Filter Box (apache#6523)

cfb6349

* Improve Filter Box * layout tweaks (cherry picked from commit 7e0e7c8)

mistercrunch mentioned this pull request Mar 12, 2019

fix(filterbox): fixed runtime exception in filterbox for allow multiple selection false #7011

Merged

michellethomas reviewed Mar 19, 2019

View reviewed changes

mistercrunch added a commit to mistercrunch/superset that referenced this pull request Mar 20, 2019

Fix filter_box migration PR apache#6523

0c65593

mistercrunch mentioned this pull request Mar 20, 2019

Fix filter_box migration PR #6523 #7066

Merged

mistercrunch added a commit that referenced this pull request Mar 21, 2019

Fix filter_box migration PR #6523 (#7066)

b210742

* Fix filter_box migration PR #6523 * Fix druid-related bug

graceguo-supercat pushed a commit that referenced this pull request Mar 21, 2019

Fix filter_box migration PR #6523 (#7066)

fe78b4e

* Fix filter_box migration PR #6523 * Fix druid-related bug (cherry picked from commit b210742)

xtinec pushed a commit that referenced this pull request Mar 25, 2019

Fix filter_box migration PR #6523 (#7066)

98cf417

* Fix filter_box migration PR #6523 * Fix druid-related bug (cherry picked from commit b210742)

thoo mentioned this pull request Jan 7, 2021

[🎉New Feature for Testing]Dashboard native filter and cascading filter are HERE! #12148

Closed

mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0 labels Feb 27, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improving Filter Box #6523

Improving Filter Box #6523

mistercrunch commented Dec 12, 2018 •

edited

Loading

mistercrunch Dec 12, 2018

codecov-io commented Dec 12, 2018 •

edited

Loading

vylc commented Dec 21, 2018

mistercrunch commented Dec 21, 2018

mistercrunch commented Dec 22, 2018 •

edited

Loading

mistercrunch commented Dec 28, 2018

mistercrunch commented Jan 10, 2019

betodealmeida commented Jan 11, 2019

kaitorecca commented Jan 23, 2019

mistercrunch commented Jan 24, 2019

michellethomas Mar 19, 2019

mistercrunch Mar 19, 2019

michellethomas commented Mar 19, 2019 •

edited

Loading

mistercrunch commented Mar 19, 2019

mistercrunch commented Mar 20, 2019

Improving Filter Box #6523

Improving Filter Box #6523

Conversation

mistercrunch commented Dec 12, 2018 • edited Loading

mistercrunch Dec 12, 2018

Choose a reason for hiding this comment

codecov-io commented Dec 12, 2018 • edited Loading

Codecov Report

vylc commented Dec 21, 2018

mistercrunch commented Dec 21, 2018

mistercrunch commented Dec 22, 2018 • edited Loading

mistercrunch commented Dec 28, 2018

mistercrunch commented Jan 10, 2019

betodealmeida commented Jan 11, 2019

kaitorecca commented Jan 23, 2019

mistercrunch commented Jan 24, 2019

michellethomas Mar 19, 2019

Choose a reason for hiding this comment

mistercrunch Mar 19, 2019

Choose a reason for hiding this comment

michellethomas commented Mar 19, 2019 • edited Loading

mistercrunch commented Mar 19, 2019

mistercrunch commented Mar 20, 2019

mistercrunch commented Dec 12, 2018 •

edited

Loading

codecov-io commented Dec 12, 2018 •

edited

Loading

mistercrunch commented Dec 22, 2018 •

edited

Loading

michellethomas commented Mar 19, 2019 •

edited

Loading