Skip to content

Commit

Permalink
[bugfix] SQL Lab 'Filter Results' doesn't stick (#7104)
Browse files Browse the repository at this point in the history
When using a "Search Results" criteria, the subset of rows that match
the criteria get displayed. While this the filter is applied, if another
query is run, the filter is still active, but not displayed in the input
text box. After this change, the state of the input box sticks after
subsequent queries.
  • Loading branch information
mistercrunch authored and xtinec committed Mar 28, 2019
1 parent ba19a62 commit d5e8d66
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion superset/assets/src/SqlLab/components/ResultSet.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -153,8 +153,9 @@ export default class ResultSet extends React.PureComponent {
<input
type="text"
onChange={this.changeSearch.bind(this)}
value={this.state.searchText}
className="form-control input-sm"
placeholder={t('Search Results')}
placeholder={t('Filter Results')}
/>
}
</div>
Expand Down

0 comments on commit d5e8d66

Please sign in to comment.