Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrapping widgets from javascript initializer. #45

Merged
merged 1 commit into from
Oct 8, 2015

Conversation

akuhn
Copy link
Contributor

@akuhn akuhn commented Oct 7, 2015

Bootstrapping widgets from a javascript initializer. Introduced a px object with registerWidget function to register a widget initializer and initializeWidget which is called on document ready and returns an object with {render, resize} functions.

Migrated word cloud, big number and nvd3 widgets.

Follow-up work

  • Migration of table and markup widget, they serve static html and will need extra migration work.
  • Break visualization into separate render and resize function, where resize doesn't fetch data.

Test plan

  • Load example dashboard.
  • Load all example slices.

Reviewers

@mistercrunch
Copy link
Member

This looks very reasonable, let's babysit the app after we merge it

@mistercrunch
Copy link
Member

img

akuhn added a commit that referenced this pull request Oct 8, 2015
Bootstrapping widgets from javascript initializer.
@akuhn akuhn merged commit b034bf9 into master Oct 8, 2015
@akuhn akuhn deleted the px_render_refresh branch October 8, 2015 18:22
hughhhh referenced this pull request in lyft/incubator-superset Apr 1, 2018
Remove extra statement for `Ensure grains.cluster_name iam role exists`  :smiling_face_with_open_mouth_and_cold_sweat:

@mistercrunch
john-bodley added a commit to john-bodley/superset that referenced this pull request May 24, 2018
…5060-5062

[cherry-picks] Picking cherries
betodealmeida pushed a commit that referenced this pull request Sep 20, 2019
graceguo-supercat pushed a commit to graceguo-supercat/superset that referenced this pull request Oct 4, 2021
zhaoyongjie referenced this pull request in zhaoyongjie/incubator-superset Nov 17, 2021
zhaoyongjie referenced this pull request in zhaoyongjie/incubator-superset Nov 17, 2021
* fix: y-axis bounds for stacked viz types

* fix: add dist_bar
zhaoyongjie referenced this pull request in zhaoyongjie/incubator-superset Nov 24, 2021
zhaoyongjie referenced this pull request in zhaoyongjie/incubator-superset Nov 24, 2021
* fix: y-axis bounds for stacked viz types

* fix: add dist_bar
zhaoyongjie referenced this pull request in zhaoyongjie/incubator-superset Nov 25, 2021
zhaoyongjie referenced this pull request in zhaoyongjie/incubator-superset Nov 25, 2021
* fix: y-axis bounds for stacked viz types

* fix: add dist_bar
zhaoyongjie referenced this pull request in zhaoyongjie/incubator-superset Nov 26, 2021
zhaoyongjie referenced this pull request in zhaoyongjie/incubator-superset Nov 26, 2021
* fix: y-axis bounds for stacked viz types

* fix: add dist_bar
zhaoyongjie referenced this pull request in zhaoyongjie/incubator-superset Nov 30, 2021
* chore: version bump

* chore: use 0.x.x to avoid future issues
rguerraZero pushed a commit to rguerraZero/superset that referenced this pull request Feb 9, 2024
Chore: Enabling role assignation for superset internal ZFE-78488
@mistercrunch mistercrunch added the 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels label Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants