fix: y-axis bounds for stacked viz types (#45)

* fix: y-axis bounds for stacked viz types * fix: add dist_bar
zhaoyongjie · Nov 25, 2021 · aa10bec · aa10bec
1 parent fc7b46e
commit aa10bec
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/.../plugins/superset-ui-plugins/packages/superset-ui-legacy-preset-chart-nvd3/src/NVD3Vis.js b/.../plugins/superset-ui-plugins/packages/superset-ui-legacy-preset-chart-nvd3/src/NVD3Vis.js
@@ -619,7 +619,13 @@ function nvd3Vis(element, props) {
         yMin = min;
         yMax = max;
       } else {
-        const [trueMin, trueMax] = computeYDomain(data);
+        let [trueMin, trueMax] = [0, 1];
+        // These viz types can be stacked
+        if (isVizTypes(['area', 'bar', 'dist_bar'])) {
+          [trueMin, trueMax] = chart.yAxis.scale().domain();
+        } else {
+          [trueMin, trueMax] = computeYDomain(data);
+        }
         yMin = hasCustomMin ? min : trueMin;
         yMax = hasCustomMax ? max : trueMax;
       }