Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add success toast to alerts and reports #19482

Merged
merged 4 commits into from
Apr 8, 2022

Conversation

pkdotson
Copy link
Member

@pkdotson pkdotson commented Apr 1, 2022

SUMMARY

This pr adds success messaging toast when user updates or creates an report or alert.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2022-03-31.at.11.44.15.PM.mov
Screen.Recording.2022-03-31.at.11.42.58.PM.mov

TESTING INSTRUCTIONS

Create and edit an alert and report and view the success toasts.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Apr 1, 2022

Codecov Report

Merging #19482 (7707a1e) into master (f91f83d) will increase coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #19482      +/-   ##
==========================================
+ Coverage   66.65%   66.68%   +0.02%     
==========================================
  Files        1680     1681       +1     
  Lines       64292    64303      +11     
  Branches     6564     6565       +1     
==========================================
+ Hits        42854    42878      +24     
+ Misses      19736    19730       -6     
+ Partials     1702     1695       -7     
Flag Coverage Δ
javascript 51.51% <0.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...frontend/src/views/CRUD/alert/AlertReportModal.tsx 52.08% <0.00%> (-0.30%) ⬇️
...ntend/packages/superset-ui-core/src/color/utils.ts 97.14% <0.00%> (-2.86%) ⬇️
...ins/legacy-plugin-chart-partition/src/Partition.js 0.00% <0.00%> (ø)
...ins/legacy-plugin-chart-sankey/src/ReactSankey.jsx 0.00% <0.00%> (ø)
...acy-plugin-chart-paired-t-test/src/PairedTTest.jsx 0.00% <0.00%> (ø)
...rt-parallel-coordinates/src/ParallelCoordinates.js 0.00% <0.00%> (ø)
...allel-coordinates/src/ReactParallelCoordinates.jsx 0.00% <0.00%> (ø)
...gacy-plugin-chart-partition/src/ReactPartition.jsx 0.00% <0.00%> (ø)
...rontend/src/visualizations/FilterBox/FilterBox.jsx 48.85% <0.00%> (+1.19%) ⬆️
superset-frontend/src/components/Select/utils.ts 63.15% <0.00%> (+5.26%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f91f83d...7707a1e. Read the comment docs.

@yousoph
Copy link
Member

yousoph commented Apr 2, 2022

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented Apr 2, 2022

@yousoph Ephemeral environment spinning up at http://35.88.112.154:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@yousoph
Copy link
Member

yousoph commented Apr 2, 2022

/testenv up FEATURE_ALERT_REPORTS=True

@github-actions
Copy link
Contributor

github-actions bot commented Apr 2, 2022

@yousoph Ephemeral environment spinning up at http://18.236.135.58:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@pkdotson pkdotson merged commit 44e3103 into apache:master Apr 8, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2022

Ephemeral environment shutdown and build artifacts deleted.

philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
* feat: add success toast to alerts and reports

* remove console

* add suggestions
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/XS 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants