feat: add success toast to alerts and reports (apache#19482)

* feat: add success toast to alerts and reports * remove console * add suggestions
ValtechMobility · Jun 9, 2022 · 3fc4270 · 3fc4270
1 parent a74e87c
commit 3fc4270
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/superset-frontend/src/views/CRUD/alert/AlertReportModal.tsx b/superset-frontend/src/views/CRUD/alert/AlertReportModal.tsx
@@ -73,6 +73,7 @@ type SelectValue = {
 };
 
 interface AlertReportModalProps {
+  addSuccessToast: (msg: string) => void;
   addDangerToast: (msg: string) => void;
   alert?: AlertObject | null;
   isReport?: boolean;
@@ -402,6 +403,7 @@ const AlertReportModal: FunctionComponent<AlertReportModalProps> = ({
   show,
   alert = null,
   isReport = false,
+  addSuccessToast,
 }) => {
   const conf = useCommonConf();
   const allowedNotificationMethods: NotificationMethodOption[] =
@@ -555,6 +557,8 @@ const AlertReportModal: FunctionComponent<AlertReportModalProps> = ({
             return;
           }
 
+          addSuccessToast(t(`${data.type} updated`));
+
           if (onAdd) {
             onAdd();
           }
@@ -569,6 +573,8 @@ const AlertReportModal: FunctionComponent<AlertReportModalProps> = ({
           return;
         }
 
+        addSuccessToast(t(`${data.type} updated`));
+
         if (onAdd) {
           onAdd(response);
         }