Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: apply d3NumberFormat to table reports #17336

Merged
merged 1 commit into from
Nov 4, 2021

Conversation

betodealmeida
Copy link
Member

SUMMARY

When sending the screenshot of a table in a report we should honor d3NumberFormat on columns.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

The chart:

Screen Shot 2021-11-03 at 9 59 11 AM

The report, before:

Screenshot 2021-11-03 at 10-07-44  Report  ch27613 ch27613b - ralmeida gmail com - Gmail

The report, after:

Screenshot 2021-11-03 at 10-08-17  Report  ch27613 ch27613b - ralmeida gmail com - Gmail

TESTING INSTRUCTIONS

  1. Create a table chart, go to customize, and set a column's "d3 format" to ,d.
  2. Create a report.
  3. Check that format matches (comma separated groups of thousands, in this case).

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Nov 3, 2021

Codecov Report

Merging #17336 (0aac847) into master (7c6d6f4) will decrease coverage by 0.18%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17336      +/-   ##
==========================================
- Coverage   77.15%   76.96%   -0.19%     
==========================================
  Files        1037     1037              
  Lines       55639    55657      +18     
  Branches     7612     7612              
==========================================
- Hits        42930    42839      -91     
- Misses      12459    12568     +109     
  Partials      250      250              
Flag Coverage Δ
hive ?
mysql 82.00% <80.00%> (+0.02%) ⬆️
postgres 82.01% <80.00%> (+0.02%) ⬆️
presto ?
python 82.09% <80.00%> (-0.37%) ⬇️
sqlite 81.68% <80.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/charts/post_processing.py 67.21% <80.00%> (+1.14%) ⬆️
superset/db_engines/hive.py 0.00% <0.00%> (-85.19%) ⬇️
superset/db_engine_specs/hive.py 69.76% <0.00%> (-17.06%) ⬇️
superset/db_engine_specs/presto.py 83.47% <0.00%> (-6.91%) ⬇️
superset/views/database/mixins.py 81.03% <0.00%> (-1.73%) ⬇️
superset/connectors/sqla/models.py 85.76% <0.00%> (-1.64%) ⬇️
superset/models/core.py 89.26% <0.00%> (-0.74%) ⬇️
superset/db_engine_specs/base.py 88.20% <0.00%> (-0.39%) ⬇️
superset/utils/core.py 90.02% <0.00%> (-0.12%) ⬇️
superset/sql_parse.py 99.42% <0.00%> (+0.02%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c6d6f4...0aac847. Read the comment docs.

@betodealmeida betodealmeida added the need:merge The PR is ready to be merged label Nov 3, 2021
Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@betodealmeida betodealmeida merged commit 03a2c6e into apache:master Nov 4, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels need:merge The PR is ready to be merged size/M 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants