-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: check roles before fetching reports #16260
fix: check roles before fetching reports #16260
Conversation
@lyndsiWilliams is working on tests for this flow. |
Codecov Report
@@ Coverage Diff @@
## master #16260 +/- ##
==========================================
- Coverage 76.72% 76.70% -0.03%
==========================================
Files 997 997
Lines 53238 53238
Branches 6772 6774 +2
==========================================
- Hits 40847 40834 -13
- Misses 12161 12174 +13
Partials 230 230
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
(cherry picked from commit 3709131)
(cherry picked from commit 3709131)
…gies * upstream/master: (64 commits) check roles before fetching reports (#16260) chore: upgrade mypy and add type guards (#16227) fix: pivot columns with ints for name (#16259) chore(pylint): Bump Pylint to 2.9.6 (#16146) fix examples tab for dashboard (#16253) chore: bump superset-ui packages to 0.17.84 (#16251) chore: Shows the dataset description in the gallery dropdown (#16200) fix(Dashboard): Omnibar dropdown visibility and keyboard commands (#16168) chore: bump py version for integration test (#16213) fix: skip perms on query context update (#16250) refactor: external metadata fetch API (#16193) feat(dao): admin can remove self from object owners (#15149) fix(dashboard): cross filter chart highlight when filters badge icon clicked (#16233) fix: validate_parameters and query (#16241) fix: Remove Advanced Analytics tag for 2 charts (#16240) Revert "feat: Changing Dataset names (#16199)" (#16235) feat: Allow users to connect via legacy SQLA form (#16201) fix: remove encryption from db params (#16214) fix(Explore): Show the tooltip only when label does not fit the container in METRICS/FILTERS/GROUP BY/SORT BY of the DATA panel (#16060) Show/hide tooltips (#16192) ... # Conflicts: # superset/tasks/caching/cache_strategy.py
(cherry picked from commit 3709131)
(cherry picked from commit 3709131)
(cherry picked from commit de5d157)
SUMMARY
This adds an extra role authorization check before fetching reports to fix a bug that was showing an unnecessary error.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Original error:
TESTING INSTRUCTIONS
As a gamma user, you should be able to go to a chart or dashboard and not receive errors about not being able to fetch reports.
ADDITIONAL INFORMATION