fix: validate_parameters and query #16241
Conversation
| id="cost_estimate_enabled" | ||
| indeterminate={false} | ||
| checked={!!db?.extra_json?.cost_query_enabled} | ||
| checked={!!db?.extra_json?.cost_estimate_enabled} |
There was a problem hiding this comment.
This was incorrect.
| // todo: ask beto where this should live | ||
| cost_query_enabled?: boolean; // in SQL Lab | ||
| version?: string; | ||
| cost_estimate_enabled?: boolean; // in SQL Lab |
There was a problem hiding this comment.
Fixed the name here too.
Codecov Report
@@ Coverage Diff @@
## master #16241 +/- ##
==========================================
+ Coverage 76.65% 76.67% +0.01%
==========================================
Files 996 996
Lines 53149 53144 -5
Branches 6770 6763 -7
==========================================
+ Hits 40743 40746 +3
+ Misses 12176 12168 -8
Partials 230 230
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| @@ -319,6 +320,18 @@ function dbReducer( | |||
| [action.payload.name]: action.payload.json, | |||
| }; | |||
| case ActionType.textChange: | |||
| if (action.payload.name === 'query_input') { | |||
There was a problem hiding this comment.
in this case, because it has a different return value, should we just make a different action name?
There was a problem hiding this comment.
Ah, good point. Yeah, makes sense.
| query = action.payload?.parameters?.query || {}; | ||
| query_input = Object.entries(query) | ||
| .map(([key, value]) => `${key}=${value}`) | ||
| .join('&'); |
There was a problem hiding this comment.
I think elsewhere we do this conversion at the input level, don't we?
There was a problem hiding this comment.
What do you mean with "at the input level"?
There was a problem hiding this comment.
I don't think we're doing this anywhere else.
With this PR we convert query to a string and store it in query_input when we fetch the database. Changes to query_input are passed to query, but this is might not survive a roundtrip (a=b& => {a: 'b'} => a=b), so we keep query_input always up to date and use it to populate the form input.
There was a problem hiding this comment.
I was thinking of what you did here, where you stored the schemas in state as an array, and then converted to a string on the input: https://github.com/betodealmeida/incubator-superset/blob/e768b3d20a554eb3da2b1f1f6910477fecaab9ee/superset-frontend/src/views/CRUD/data/database/DatabaseModal/ExtraOptions.tsx#L377
But maybe that won't work here.. I think it's ok to leave this as is.. I was thinking consistency and keeping the state as simple as possible.
There was a problem hiding this comment.
It works for the array because the roundtrip preserves the text in the form:
a => ['a'] => a
a, => ['a', ''] => a,
But for query we need to store the intermediary value for cases like this:
a=1&b => {a: 1, b: ''} => a=1&b=
* fix: validate_parameters and query * add onQueryChange (cherry picked from commit 5d3d6b6)
* fix: validate_parameters and query * add onQueryChange (cherry picked from commit 5d3d6b6)
…gies * upstream/master: (64 commits) check roles before fetching reports (#16260) chore: upgrade mypy and add type guards (#16227) fix: pivot columns with ints for name (#16259) chore(pylint): Bump Pylint to 2.9.6 (#16146) fix examples tab for dashboard (#16253) chore: bump superset-ui packages to 0.17.84 (#16251) chore: Shows the dataset description in the gallery dropdown (#16200) fix(Dashboard): Omnibar dropdown visibility and keyboard commands (#16168) chore: bump py version for integration test (#16213) fix: skip perms on query context update (#16250) refactor: external metadata fetch API (#16193) feat(dao): admin can remove self from object owners (#15149) fix(dashboard): cross filter chart highlight when filters badge icon clicked (#16233) fix: validate_parameters and query (#16241) fix: Remove Advanced Analytics tag for 2 charts (#16240) Revert "feat: Changing Dataset names (#16199)" (#16235) feat: Allow users to connect via legacy SQLA form (#16201) fix: remove encryption from db params (#16214) fix(Explore): Show the tooltip only when label does not fit the container in METRICS/FILTERS/GROUP BY/SORT BY of the DATA panel (#16060) Show/hide tooltips (#16192) ... # Conflicts: # superset/tasks/caching/cache_strategy.py
* fix: validate_parameters and query * add onQueryChange
* fix: validate_parameters and query * add onQueryChange (cherry picked from commit 5d3d6b6)
* fix: validate_parameters and query * add onQueryChange
* fix: validate_parameters and query * add onQueryChange (cherry picked from commit 5d3d6b6)
* fix: validate_parameters and query * add onQueryChange (cherry picked from commit 1753631)
mistercrunch
added
🍒 1.3.0
🍒 1.3.1
🍒 1.3.2
🏷️ bot
SUMMARY
When calling
validate_parameterswe're passingqueryas a string, not an object. This breaks the validation of parameters.We still have 2 attributes with mixed types, we should fix them to prevent bugs like this:
superset/superset-frontend/src/views/CRUD/data/database/types.ts
Lines 77 to 80 in 1715143
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION