Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add stack trace to all calls of logger.error #14382

Merged
merged 1 commit into from
Apr 30, 2021

Conversation

samtfm
Copy link
Contributor

@samtfm samtfm commented Apr 27, 2021

SUMMARY

Occasionally we see error logs in Sentry with no backtrace, making it hard to figure out what's going wrong in Superset.

This change adds exc_info=True to all logger.error calls so that we get a stacktrace on all the error messages that make it to Sentry.

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@samtfm samtfm marked this pull request as ready for review April 28, 2021 17:44
@codecov
Copy link

codecov bot commented Apr 28, 2021

Codecov Report

Merging #14382 (150fa4c) into master (4fbb572) will decrease coverage by 0.00%.
The diff coverage is 10.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14382      +/-   ##
==========================================
- Coverage   77.14%   77.13%   -0.01%     
==========================================
  Files         954      954              
  Lines       48136    48132       -4     
  Branches     5986     5986              
==========================================
- Hits        37133    37129       -4     
  Misses      10806    10806              
  Partials      197      197              
Flag Coverage Δ
hive 80.77% <10.00%> (-0.01%) ⬇️
mysql 81.03% <10.00%> (-0.01%) ⬇️
postgres 81.06% <10.00%> (-0.01%) ⬇️
presto 80.76% <10.00%> (-0.01%) ⬇️
python 81.60% <10.00%> (-0.01%) ⬇️
sqlite 80.67% <10.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/annotation_layers/annotations/api.py 84.96% <ø> (ø)
superset/annotation_layers/api.py 83.19% <ø> (ø)
superset/cachekeys/api.py 96.15% <ø> (ø)
superset/charts/api.py 81.81% <ø> (ø)
superset/common/query_context.py 82.16% <ø> (ø)
superset/dashboards/api.py 87.76% <ø> (ø)
superset/databases/api.py 92.33% <0.00%> (ø)
superset/datasets/api.py 91.51% <0.00%> (ø)
superset/datasets/columns/api.py 100.00% <ø> (ø)
superset/datasets/commands/bulk_delete.py 87.23% <ø> (ø)
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fbb572...150fa4c. Read the comment docs.

@nytai nytai merged commit 11260b3 into apache:master Apr 30, 2021
@nytai nytai deleted the samtfm/add-stacktrace-to-sentry-logs branch April 30, 2021 16:22
amitmiran137 pushed a commit to nielsen-oss/superset that referenced this pull request May 3, 2021
* master: (38 commits)
  refactor(native-filters): allow cascading only for filter_select (apache#14441)
  test(maximize-chart): Add tests to maximize chart action (apache#14371)
  fix: fixing mysql error message (apache#14416)
  feat: Logic added to limiting factor column in Query model (apache#13521)
  change relationship (apache#14435)
  fix: bootstrap data permissions (apache#14348)
  fix: parse simple string error message values (apache#14360)
  chore: add stack trace to all calls of logger.error (apache#14382)
  update README with new docs and recordings (apache#14432)
  Renamed impyla from implya in impala.mdx and Renamed PIP package impyla from impala in index.mdx (apache#14425)
  fix(native-filters): fix filter scope error (apache#14426)
  feat: Adding limiting_factor column to Query model (apache#14234)
  feat: Add etag caching to dashboard APIs (apache#14357)
  chore: Moves Card to the components folder (apache#14139)
  feat: Dynamic imports for the Icons component (apache#14318)
  feat: Support env vars configuration for WebSocket server (apache#14398)
  fix: SQLLab role permissions (apache#14372)
  fix(native-filters): always show filters without dataset (apache#14409)
  fix error getting partitionQuery from table.partition (apache#14369)
  refactor: Boostrap to AntD - Tabs (apache#14048)
  ...
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants