chore: add stack trace to all calls of logger.error (#14382)

superset/annotation_layers/annotations/api.py

@@ -311,7 +311,10 @@ def post(self, pk: int) -> Response:  # pylint: disable=arguments-differ
             return self.response_422(message=ex.normalized_messages())
         except AnnotationCreateFailedError as ex:
             logger.error(
-                "Error creating annotation %s: %s", self.__class__.__name__, str(ex)
+                "Error creating annotation %s: %s",
+                self.__class__.__name__,
+                str(ex),
+                exc_info=True,
             )
             return self.response_422(message=str(ex))
 
@@ -384,7 +387,10 @@ def put(  # pylint: disable=arguments-differ
             return self.response_422(message=ex.normalized_messages())
         except AnnotationUpdateFailedError as ex:
             logger.error(
-                "Error updating annotation %s: %s", self.__class__.__name__, str(ex)
+                "Error updating annotation %s: %s",
+                self.__class__.__name__,
+                str(ex),
+                exc_info=True,
             )
             return self.response_422(message=str(ex))
 
@@ -436,7 +442,10 @@ def delete(  # pylint: disable=arguments-differ
             return self.response_404()
         except AnnotationDeleteFailedError as ex:
             logger.error(
-                "Error deleting annotation %s: %s", self.__class__.__name__, str(ex)
+                "Error deleting annotation %s: %s",
+                self.__class__.__name__,
+                str(ex),
+                exc_info=True,
             )
             return self.response_422(message=str(ex))
 

superset/annotation_layers/api.py

@@ -158,6 +158,7 @@ def delete(self, pk: int) -> Response:
                 "Error deleting annotation layer %s: %s",
                 self.__class__.__name__,
                 str(ex),
+                exc_info=True,
             )
             return self.response_422(message=str(ex))
 
@@ -220,7 +221,10 @@ def post(self) -> Response:
             return self.response_422(message=ex.normalized_messages())
         except AnnotationLayerCreateFailedError as ex:
             logger.error(
-                "Error creating annotation %s: %s", self.__class__.__name__, str(ex)
+                "Error creating annotation %s: %s",
+                self.__class__.__name__,
+                str(ex),
+                exc_info=True,
             )
             return self.response_422(message=str(ex))
 
@@ -290,7 +294,10 @@ def put(self, pk: int) -> Response:
             return self.response_422(message=ex.normalized_messages())
         except AnnotationLayerUpdateFailedError as ex:
             logger.error(
-                "Error updating annotation %s: %s", self.__class__.__name__, str(ex)
+                "Error updating annotation %s: %s",
+                self.__class__.__name__,
+                str(ex),
+                exc_info=True,
             )
             return self.response_422(message=str(ex))
 

superset/cachekeys/api.py

@@ -122,7 +122,7 @@ def invalidate(self) -> Response:
                     len(datasource_uids),
                 )
             except SQLAlchemyError as ex:  # pragma: no cover
-                logger.error(ex)
+                logger.error(ex, exc_info=True)
                 db.session.rollback()
                 return self.response_500(str(ex))
             db.session.commit()

superset/charts/api.py

@@ -277,7 +277,10 @@ def post(self) -> Response:
             return self.response_422(message=ex.normalized_messages())
         except ChartCreateFailedError as ex:
             logger.error(
-                "Error creating model %s: %s", self.__class__.__name__, str(ex)
+                "Error creating model %s: %s",
+                self.__class__.__name__,
+                str(ex),
+                exc_info=True,
             )
             return self.response_422(message=str(ex))
 
@@ -352,7 +355,10 @@ def put(self, pk: int) -> Response:
             response = self.response_422(message=ex.normalized_messages())
         except ChartUpdateFailedError as ex:
             logger.error(
-                "Error updating model %s: %s", self.__class__.__name__, str(ex)
+                "Error updating model %s: %s",
+                self.__class__.__name__,
+                str(ex),
+                exc_info=True,
             )
             response = self.response_422(message=str(ex))
 
@@ -407,7 +413,10 @@ def delete(self, pk: int) -> Response:
             return self.response_403()
         except ChartDeleteFailedError as ex:
             logger.error(
-                "Error deleting model %s: %s", self.__class__.__name__, str(ex)
+                "Error deleting model %s: %s",
+                self.__class__.__name__,
+                str(ex),
+                exc_info=True,
             )
             return self.response_422(message=str(ex))
 

superset/common/query_context.py

@@ -332,7 +332,9 @@ def get_df_payload(  # pylint: disable=too-many-statements,too-many-locals
                 except KeyError as ex:
                     logger.exception(ex)
                     logger.error(
-                        "Error reading cache: %s", error_msg_from_exception(ex)
+                        "Error reading cache: %s",
+                        error_msg_from_exception(ex),
+                        exc_info=True,
                     )
                 logger.info("Serving from cache")
 

superset/dashboards/api.py

@@ -459,7 +459,10 @@ def post(self) -> Response:
             return self.response_422(message=ex.normalized_messages())
         except DashboardCreateFailedError as ex:
             logger.error(
-                "Error creating model %s: %s", self.__class__.__name__, str(ex)
+                "Error creating model %s: %s",
+                self.__class__.__name__,
+                str(ex),
+                exc_info=True,
             )
             return self.response_422(message=str(ex))
 
@@ -532,7 +535,10 @@ def put(self, pk: int) -> Response:
             return self.response_422(message=ex.normalized_messages())
         except DashboardUpdateFailedError as ex:
             logger.error(
-                "Error updating model %s: %s", self.__class__.__name__, str(ex)
+                "Error updating model %s: %s",
+                self.__class__.__name__,
+                str(ex),
+                exc_info=True,
             )
             response = self.response_422(message=str(ex))
         return response
@@ -586,7 +592,10 @@ def delete(self, pk: int) -> Response:
             return self.response_403()
         except DashboardDeleteFailedError as ex:
             logger.error(
-                "Error deleting model %s: %s", self.__class__.__name__, str(ex)
+                "Error deleting model %s: %s",
+                self.__class__.__name__,
+                str(ex),
+                exc_info=True,
             )
             return self.response_422(message=str(ex))
 

superset/databases/api.py

@@ -243,7 +243,10 @@ def post(self) -> Response:
             return self.response_422(message=str(ex))
         except DatabaseCreateFailedError as ex:
             logger.error(
-                "Error creating model %s: %s", self.__class__.__name__, str(ex)
+                "Error creating model %s: %s",
+                self.__class__.__name__,
+                str(ex),
+                exc_info=True,
             )
             return self.response_422(message=str(ex))
 
@@ -320,7 +323,10 @@ def put(  # pylint: disable=too-many-return-statements, arguments-differ
             return self.response_422(message=str(ex))
         except DatabaseUpdateFailedError as ex:
             logger.error(
-                "Error updating model %s: %s", self.__class__.__name__, str(ex)
+                "Error updating model %s: %s",
+                self.__class__.__name__,
+                str(ex),
+                exc_info=True,
             )
             return self.response_422(message=str(ex))
 
@@ -373,7 +379,10 @@ def delete(self, pk: int) -> Response:  # pylint: disable=arguments-differ
             return self.response_422(message=str(ex))
         except DatabaseDeleteFailedError as ex:
             logger.error(
-                "Error deleting model %s: %s", self.__class__.__name__, str(ex)
+                "Error deleting model %s: %s",
+                self.__class__.__name__,
+                str(ex),
+                exc_info=True,
             )
             return self.response_422(message=str(ex))
 
@@ -800,7 +809,7 @@ def import_(self) -> Response:
             logger.warning("Import database failed")
             return self.response_422(message=exc.normalized_messages())
         except DatabaseImportError as exc:
-            logger.error("Import database failed")
+            logger.error("Import database failed", exc_info=True)
             return self.response_500(message=str(exc))
 
     @expose("/<int:pk>/function_names/", methods=["GET"])

superset/datasets/api.py

@@ -239,7 +239,10 @@ def post(self) -> Response:
             return self.response_422(message=ex.normalized_messages())
         except DatasetCreateFailedError as ex:
             logger.error(
-                "Error creating model %s: %s", self.__class__.__name__, str(ex)
+                "Error creating model %s: %s",
+                self.__class__.__name__,
+                str(ex),
+                exc_info=True,
             )
             return self.response_422(message=str(ex))
 
@@ -325,7 +328,10 @@ def put(self, pk: int) -> Response:
             response = self.response_422(message=ex.normalized_messages())
         except DatasetUpdateFailedError as ex:
             logger.error(
-                "Error updating model %s: %s", self.__class__.__name__, str(ex)
+                "Error updating model %s: %s",
+                self.__class__.__name__,
+                str(ex),
+                exc_info=True,
             )
             response = self.response_422(message=str(ex))
         return response
@@ -379,7 +385,10 @@ def delete(self, pk: int) -> Response:
             return self.response_403()
         except DatasetDeleteFailedError as ex:
             logger.error(
-                "Error deleting model %s: %s", self.__class__.__name__, str(ex)
+                "Error deleting model %s: %s",
+                self.__class__.__name__,
+                str(ex),
+                exc_info=True,
             )
             return self.response_422(message=str(ex))
 
@@ -512,7 +521,10 @@ def refresh(self, pk: int) -> Response:
             return self.response_403()
         except DatasetRefreshFailedError as ex:
             logger.error(
-                "Error refreshing dataset %s: %s", self.__class__.__name__, str(ex)
+                "Error refreshing dataset %s: %s",
+                self.__class__.__name__,
+                str(ex),
+                exc_info=True,
             )
             return self.response_422(message=str(ex))
 
@@ -716,5 +728,5 @@ def import_(self) -> Response:
             logger.warning("Import dataset failed")
             return self.response_422(message=exc.normalized_messages())
         except DatasetImportError as exc:
-            logger.error("Import dataset failed")
+            logger.error("Import dataset failed", exc_info=True)
             return self.response_500(message=str(exc))

superset/datasets/columns/api.py

@@ -99,6 +99,9 @@ def delete(  # pylint: disable=arguments-differ
             return self.response_403()
         except DatasetColumnDeleteFailedError as ex:
             logger.error(
-                "Error deleting dataset column %s: %s", self.__class__.__name__, str(ex)
+                "Error deleting dataset column %s: %s",
+                self.__class__.__name__,
+                str(ex),
+                exc_info=True,
             )
             return self.response_422(message=str(ex))

superset/datasets/commands/bulk_delete.py

@@ -66,7 +66,8 @@ def run(self) -> None:
                 else:
                     if not view_menu:
                         logger.error(
-                            "Could not find the data access permission for the dataset"
+                            "Could not find the data access permission for the dataset",
+                            exc_info=True,
                         )
             db.session.commit()
 

superset/datasets/commands/delete.py

@@ -68,7 +68,8 @@ def run(self) -> Model:
             else:
                 if not view_menu:
                     logger.error(
-                        "Could not find the data access permission for the dataset"
+                        "Could not find the data access permission for the dataset",
+                        exc_info=True,
                     )
             db.session.commit()
         except (SQLAlchemyError, DAODeleteFailedError) as ex:

superset/datasets/dao.py

@@ -48,7 +48,7 @@ def get_database_by_id(database_id: int) -> Optional[Database]:
         try:
             return db.session.query(Database).filter_by(id=database_id).one_or_none()
         except SQLAlchemyError as ex:  # pragma: no cover
-            logger.error("Could not get database by id: %s", str(ex))
+            logger.error("Could not get database by id: %s", str(ex), exc_info=True)
             return None
 
     @staticmethod

superset/datasets/metrics/api.py

@@ -99,6 +99,9 @@ def delete(  # pylint: disable=arguments-differ
             return self.response_403()
         except DatasetMetricDeleteFailedError as ex:
             logger.error(
-                "Error deleting dataset column %s: %s", self.__class__.__name__, str(ex)
+                "Error deleting dataset column %s: %s",
+                self.__class__.__name__,
+                str(ex),
+                exc_info=True,
             )
             return self.response_422(message=str(ex))

superset/db_engine_specs/base.py

@@ -836,7 +836,7 @@ def get_table_comment(
             # It's expected that some dialects don't implement the comment method
             pass
         except Exception as ex:  # pylint: disable=broad-except
-            logger.error("Unexpected error while fetching table comment")
+            logger.error("Unexpected error while fetching table comment", exc_info=True)
             logger.exception(ex)
         return comment
 
@@ -1218,7 +1218,7 @@ def get_extra_params(database: "Database") -> Dict[str, Any]:
             try:
                 extra = json.loads(database.extra)
             except json.JSONDecodeError as ex:
-                logger.error(ex)
+                logger.error(ex, exc_info=True)
                 raise ex
         return extra
 

superset/db_engine_specs/hive.py

@@ -523,6 +523,7 @@ def get_function_names(cls, database: "Database") -> List[str]:
             "Expected column `%s`, found: %s.",
             cls._show_functions_column,
             ", ".join(columns),
+            exc_info=True,
         )
         # if the results have a single column, use that
         if len(columns) == 1:

superset/models/core.py

@@ -176,7 +176,9 @@ def function_names(self) -> List[str]:
             # function_names property is used in bulk APIs and should not hard crash
             # more info in: https://github.com/apache/superset/issues/9678
             logger.error(
-                "Failed to fetch database function names with error: %s", str(ex)
+                "Failed to fetch database function names with error: %s",
+                str(ex),
+                exc_info=True,
             )
         return []
 
@@ -594,7 +596,7 @@ def get_encrypted_extra(self) -> Dict[str, Any]:
             try:
                 encrypted_extra = json.loads(self.encrypted_extra)
             except json.JSONDecodeError as ex:
-                logger.error(ex)
+                logger.error(ex, exc_info=True)
                 raise ex
         return encrypted_extra
 

superset/models/helpers.py

@@ -213,6 +213,7 @@ def import_from_dict(
                 cls.__name__,
                 str(obj_query),
                 yaml.safe_dump(dict_rep),
+                exc_info=True,
             )
             raise ex
 

superset/models/slice.py

@@ -223,7 +223,7 @@ def form_data(self) -> Dict[str, Any]:
         try:
             form_data = json.loads(self.params)
         except Exception as ex:  # pylint: disable=broad-except
-            logger.error("Malformed json in slice's params")
+            logger.error("Malformed json in slice's params", exc_info=True)
             logger.exception(ex)
         form_data.update(
             {