Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attach topic and custom labels to Prometheus metrics #410

Merged
merged 5 commits into from
Dec 10, 2020
Merged

Attach topic and custom labels to Prometheus metrics #410

merged 5 commits into from
Dec 10, 2020

Conversation

merlimat
Copy link
Contributor

@merlimat merlimat commented Dec 8, 2020

Motivation

  1. Tag metrics with Pulsar tenant, namespace and topic labels.
  2. Allow user to specify custom metric label to attach

@merlimat merlimat added this to the 0.4.0 milestone Dec 8, 2020
@merlimat merlimat self-assigned this Dec 8, 2020
wolfstudy
wolfstudy approved these changes Dec 10, 2020
View reviewed changes
Copy link
Member

@wolfstudy wolfstudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@merlimat merlimat merged commit 21541d6 into apache:master Dec 10, 2020
@merlimat merlimat mentioned this pull request Dec 14, 2020
Merged
@michaeljmarshall michaeljmarshall mentioned this pull request Apr 1, 2021
Closed
@sijie sijie mentioned this pull request Apr 1, 2021
Closed
@flowchartsman flowchartsman mentioned this pull request Aug 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolfstudy wolfstudy wolfstudy approved these changes

@aahmed-se aahmed-se Awaiting requested review from aahmed-se

@jerrypeng jerrypeng Awaiting requested review from jerrypeng

@srkukarni srkukarni Awaiting requested review from srkukarni

Assignees

@merlimat merlimat

Labels
type/feature
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@merlimat @wolfstudy