Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE-500: Make Topic Level Prometheus Metrics Optional #172

Closed
sijie opened this issue Apr 1, 2021 · 0 comments
Closed

ISSUE-500: Make Topic Level Prometheus Metrics Optional #172

sijie opened this issue Apr 1, 2021 · 0 comments

Comments

@sijie
Copy link
Member

sijie commented Apr 1, 2021

Original Issue: apache#500


Is your feature request related to a problem? Please describe.
In 0.4.0, apache#410 introduced topic level prometheus metrics. When consuming from or publishing to many topics, this creates many metrics and can cause problems for applications and/or prometheus instances. In my case, I saw up to 900k metrics produced by a single client, which caused memory problems in my application and temporarily brought down my prometheus server.

Describe the solution you'd like
I would like to be able to enable or disable the topic level metrics. I think these topic level metrics should be disabled by default, since that was the previous behavior.

Describe alternatives you've considered
I looked into the code introduced in 0.4.0, and I don't see any ways to prevent these metrics from being created currently.

Additional context
I like the metrics I get out of the client in 0.3.0. I think it's great to have them out of the box.

Also, the cardinality of metrics is preventing me from upgrading my go client from 0.3.0 to 0.4.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant