Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[1.x] Fix race condition in NaiveEngine::PushAsync #19122

Merged
merged 1 commit into from
Sep 13, 2020

Commits on Sep 11, 2020

  1. Fix race condition in NaiveEngine::PushAsync (apache#19108)

    * Wait for async_fun to complete in NaiveEngine::PushAsync
    
    This fixes a race condition in which NaiveEngine::PushAsync was checking if the
    the async_fun had completed by the end of NaiveEngine::PushAsync. If async_fun
    hadn't completed yet, NaiveEngine::PushAsync would set an internal error string
    and deallocate the callback, causing segfault in async_fun once it would attempt
    calling the callback.
    
    * Update naive_engine.cc
    leezu committed Sep 11, 2020
    Configuration menu
    Copy the full SHA
    29cc400 View commit details
    Browse the repository at this point in the history