Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[1.x] Fix race condition in NaiveEngine::PushAsync #19122

Merged
merged 1 commit into from
Sep 13, 2020
Merged

[1.x] Fix race condition in NaiveEngine::PushAsync #19122

merged 1 commit into from
Sep 13, 2020

Conversation

leezu
Copy link
Contributor

@leezu leezu commented Sep 11, 2020

Backport #19108

@leezu
Fix race condition in NaiveEngine::PushAsync (apache#19108)
29cc400 
* Wait for async_fun to complete in NaiveEngine::PushAsync

This fixes a race condition in which NaiveEngine::PushAsync was checking if the
the async_fun had completed by the end of NaiveEngine::PushAsync. If async_fun
hadn't completed yet, NaiveEngine::PushAsync would set an internal error string
and deallocate the callback, causing segfault in async_fun once it would attempt
calling the callback.

* Update naive_engine.cc
@mxnet-bot
Copy link

Hey @leezu , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [website, windows-gpu, miscellaneous, edge, centos-cpu, unix-cpu, centos-gpu, sanity, unix-gpu, windows-cpu, clang]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@leezu leezu mentioned this pull request Sep 11, 2020
Open
samskalicky
samskalicky approved these changes Sep 11, 2020
View reviewed changes
Copy link
Contributor

@samskalicky samskalicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@leezu
Copy link
Contributor Author

leezu commented Sep 11, 2020

@mxnet-bot run ci [centos-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [centos-gpu]

@szha szha merged commit 8b56874 into apache:v1.x Sep 13, 2020
@leezu leezu deleted the 1xnaiveenginepushasync branch September 13, 2020 22:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samskalicky samskalicky samskalicky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@leezu @mxnet-bot @samskalicky @szha