Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add polaris extensions support #184

Merged
merged 7 commits into from
Dec 13, 2022
Merged

Add polaris extensions support #184

merged 7 commits into from
Dec 13, 2022

Conversation

andrewshan
Copy link
Contributor

What is the purpose of the change

Add the polaris extensions to make dubbo2.7.x access polaris

Brief changelog

#91

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before
    you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address
    just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit
    in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency
    exist. If the new feature or significant change is committed, please remember to add sample
    in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure
    unit-test and integration-test pass.
  • If this contribution is large, please follow
    the Software Donation Guide.

@codecov-commenter
Copy link

codecov-commenter commented Dec 11, 2022

Codecov Report

Merging #184 (8fc5151) into master (9312264) will increase coverage by 4.41%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #184      +/-   ##
============================================
+ Coverage     34.27%   38.68%   +4.41%     
+ Complexity      516      488      -28     
============================================
  Files           151      140      -11     
  Lines          5313     4513     -800     
  Branches        657      570      -87     
============================================
- Hits           1821     1746      -75     
+ Misses         3292     2569     -723     
+ Partials        200      198       -2     
Impacted Files Coverage Δ
...che/dubbo/remoting/transport/mina/MinaChannel.java 35.52% <0.00%> (-10.53%) ⬇️
...org/apache/dubbo/registry/redis/RedisRegistry.java 52.05% <0.00%> (-2.63%) ⬇️
...he/dubbo/rpc/protocol/hessian/HessianProtocol.java 77.64% <0.00%> (-2.36%) ⬇️
...g/apache/dubbo/registry/consul/ConsulRegistry.java
.../support/etcd/EtcdDynamicConfigurationFactory.java
.../dubbo/registry/consul/ConsulServiceDiscovery.java
.../apache/dubbo/remoting/etcd/jetcd/RetryNTimes.java
.../dubbo/metadata/store/etcd/EtcdMetadataReport.java
...ubbo/remoting/etcd/support/AbstractEtcdClient.java
...java/org/apache/dubbo/remoting/etcd/Constants.java
... and 20 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please enhance uts. Ohters LGTM

@AlbumenJ AlbumenJ merged commit 12a5931 into apache:master Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants