fix: add version specific and comment in English

apache · Dec 13, 2022 · 8fc5151 · 8fc5151
1 parent 1674610
commit 8fc5151
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 2 deletions.
diff --git a/dubbo-cluster-extensions/dubbo-cluster-polaris-dubbo2/pom.xml b/dubbo-cluster-extensions/dubbo-cluster-polaris-dubbo2/pom.xml
@@ -27,6 +27,9 @@
     <modelVersion>4.0.0</modelVersion>
 
     <artifactId>dubbo-cluster-polaris-dubbo2</artifactId>
+    <name>dubbo-cluster-polaris-dubbo2</name>
+    <version>1.0.0-SNAPSHOT</version>
+    <description>Dubbo2 cluster extension for PolarisMesh, support dynamic routing capability.</description>
 
     <dependencies>
         <dependency>

diff --git a/dubbo-filter-extensions/dubbo-filter-polaris-dubbo2/pom.xml b/dubbo-filter-extensions/dubbo-filter-polaris-dubbo2/pom.xml
@@ -27,6 +27,9 @@
     <modelVersion>4.0.0</modelVersion>
 
     <artifactId>dubbo-filter-polaris-dubbo2</artifactId>
+    <name>dubbo-filter-polaris-dubbo2</name>
+    <version>1.0.0-SNAPSHOT</version>
+    <description>Dubbo2 filter extension for PolarisMesh, support circuitbreaking, ratelimit, metric capabilities.</description>
 
     <dependencies>
         <dependency>

diff --git a/...o-filter-polaris-dubbo2/src/main/java/org/apache/dubbo/filter/dubbo2/RateLimitFilter.java b/...o-filter-polaris-dubbo2/src/main/java/org/apache/dubbo/filter/dubbo2/RateLimitFilter.java
@@ -98,7 +98,7 @@ public Result invoke(Invoker<?> invoker, Invocation invocation) throws RpcExcept
             LOGGER.error("[POLARIS] get quota fail", e);
         }
         if (null != quotaResponse && quotaResponse.getCode() == QuotaResultCode.QuotaResultLimited) {
-            // 请求被限流，则抛出异常
+            // throw block exception when ratelimit occurs
             throw new RpcException(RpcException.LIMIT_EXCEEDED_EXCEPTION, new PolarisBlockException(
                     String.format("url=%s, info=%s", invoker.getUrl(), quotaResponse.getInfo())));
         }

diff --git a/...ubbo-filter-polaris-dubbo2/src/main/java/org/apache/dubbo/filter/dubbo2/ReportFilter.java b/...ubbo-filter-polaris-dubbo2/src/main/java/org/apache/dubbo/filter/dubbo2/ReportFilter.java
@@ -69,7 +69,7 @@ public Result invoke(Invoker<?> invoker, Invocation invocation) throws RpcExcept
             if (null != rpcException) {
                 code = rpcException.getCode();
                 if (code == RpcException.LIMIT_EXCEEDED_EXCEPTION) {
-                    // 限流异常不进行熔断
+                    // we won't consider limit exception as error
                     retStatus = RetStatus.RetSuccess;
                 }
             } else {

diff --git a/dubbo-registry-extensions/dubbo-registry-polaris/pom.xml b/dubbo-registry-extensions/dubbo-registry-polaris/pom.xml
@@ -24,6 +24,9 @@
     <modelVersion>4.0.0</modelVersion>
 
     <artifactId>dubbo-registry-polaris</artifactId>
+    <name>dubbo-registry-polaris</name>
+    <version>1.0.0-SNAPSHOT</version>
+    <description>Dubbo registry extension for PolarisMesh, support instance register, discover, health-check capabilities.</description>
 
     <dependencies>
         <dependency>