Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RunInference API to CHANGES.md #21754

Merged
merged 3 commits into from
Jun 13, 2022
Merged

Add RunInference API to CHANGES.md #21754

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ccc9fab
Add RunInference to Changes.md
yeandy Jun 8, 2022
1299756
Fix typo
yeandy Jun 8, 2022
6c99c52
Change text
yeandy Jun 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,8 @@

## Highlights

* New highly anticipated feature X added to Python SDK ([BEAM-X](https://issues.apache.org/jira/browse/BEAM-X)).
* New highly anticipated feature Y added to Java SDK ([BEAM-Y](https://issues.apache.org/jira/browse/BEAM-Y)).
* Initial preview of the [RunInference](https://s.apache.org/inference-sklearn-pytorch) API added to Python SDK ([BEAM-13970](https://issues.apache.org/jira/browse/BEAM-13970)).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to call it a preview here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bad wording on my part. How does this sound: "Added the new RunInference API to the Python SDK. Users can now make inferences with PyTorch and Scikit-learn models!". Open to suggestions/changes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that sounds better to me. You might also check with @rezarokni to see how he wants to message it. (might need to reach out to him directly, I don't know that he'll see a ping from GitHub).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about "Added RunInference API, a framework agnostic transform for inference. With this release PyTorch() and Scikit-learn () are supported by the transform.

See also example at apache_beam/examples/inference/pytorch_image_classification.py

## I/Os

Expand Down