-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RunInference API to CHANGES.md #21754
Conversation
Can one of the admins verify this patch? |
2 similar comments
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
CHANGES.md
Outdated
@@ -53,8 +53,8 @@ | |||
|
|||
## Highlights | |||
|
|||
* New highly anticipated feature X added to Python SDK ([BEAM-X](https://issues.apache.org/jira/browse/BEAM-X)). | |||
* New highly anticipated feature Y added to Java SDK ([BEAM-Y](https://issues.apache.org/jira/browse/BEAM-Y)). | |||
* Initial preview of the [RunInference](https://s.apache.org/inference-sklearn-pytorch) API added to Python SDK ([BEAM-13970](https://issues.apache.org/jira/browse/BEAM-13970)). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to call it a preview here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bad wording on my part. How does this sound: "Added the new RunInference API to the Python SDK. Users can now make inferences with PyTorch and Scikit-learn models!". Open to suggestions/changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that sounds better to me. You might also check with @rezarokni to see how he wants to message it. (might need to reach out to him directly, I don't know that he'll see a ping from GitHub).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about "Added RunInference API, a framework agnostic transform for inference. With this release PyTorch() and Scikit-learn () are supported by the transform.
@rezarokni PTAL |
* Add RunInference to Changes.md * Fix typo * Change text
Adding a note on the new RunInference API to CHANGES.md
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.