Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

fix(plugin-chart-echarts): fix tooltip format in mixed ts chart #1143

Merged

Conversation

villebro
Copy link
Contributor

@villebro villebro commented Jun 2, 2021

🐛 Bug Fix

Currently the Mixed Timeseries chart doesn't consider the secondary axis formatter when rendering the tooltip.

BEFORE

Despite "girls" referencing the secondary axis (right) that applies a different formatter than the primary axis (left), the secondary axis format isn't applied in the tooltip (now displays "658k", should be "657586"):
image

AFTER

Now the tooltip format is set based on the format defined for the axis.
image

Fixes apache/superset#14943

@villebro villebro requested a review from a team as a code owner June 2, 2021 06:45
@vercel
Copy link

vercel bot commented Jun 2, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/8zA2QB2UBvD4zjpw6VX3CjLJrz5R
✅ Preview: https://superset-ui-git-fork-preset-io-villebro-fix-multi-for-83e733.vercel.app

@codecov
Copy link

codecov bot commented Jun 2, 2021

Codecov Report

Merging #1143 (4e1db86) into master (9174f86) will decrease coverage by 0.02%.
The diff coverage is 8.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1143      +/-   ##
==========================================
- Coverage   28.97%   28.95%   -0.03%     
==========================================
  Files         463      463              
  Lines        9310     9319       +9     
  Branches     1486     1488       +2     
==========================================
  Hits         2698     2698              
- Misses       6400     6409       +9     
  Partials      212      212              
Impacted Files Coverage Δ
...hart-echarts/src/MixedTimeseries/transformProps.ts 0.00% <0.00%> (ø)
...lugin-chart-echarts/src/Timeseries/transformers.ts 56.57% <ø> (ø)
...gin-chart-echarts/src/Timeseries/transformProps.ts 53.19% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9174f86...4e1db86. Read the comment docs.

Copy link
Contributor

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks for this fix.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
2 participants