Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mixed time-series] Separate Y-axis bounds, Label values and Tooltip formatting #15672

Closed
kamalkeshavani-aiinside opened this issue Jul 14, 2021 · 6 comments
Labels
enhancement:request Enhancement request submitted by anyone from the community viz:charts:echarts Related to Echarts

Comments

@kamalkeshavani-aiinside
Copy link
Contributor

kamalkeshavani-aiinside commented Jul 14, 2021

Is your feature request related to a problem? Please describe.

  1. Currently there is an option to set Y-axis bounds, but it applies to both primary and secondary y-axis at the same time. This is not really helpful since both axis will mostly have different scales.
  2. We cannot see the value labels in the chart, so the user always has to rely on tooltip to look at the data.
  3. Tooltip is always showing adaptive formatting for X-axis and Secondary Y-axis values.

Describe the solution you'd like

  1. There should be an option to set bounds separately for both primary and secondary y-axis.
  2. There should be an option to show value labels(currently available only in Bar chart)
  3. d3 formatting set by user should be shown in tooltip for all the axis values.

Describe alternatives you've considered

Additional context

@kamalkeshavani-aiinside kamalkeshavani-aiinside changed the title [mixed time-series] Separate Y-axis bounds and Tooltip formatting [mixed time-series] Separate Y-axis bounds, Label values and Tooltip formatting Jul 14, 2021
@junlincc
Copy link
Member

thanks for suggesting! all good point and well accepted. Let us know if would like to collaborate on this, as it will take awhile for us to start the next iteration that incorporates those changes. 🙏

@junlincc junlincc added the enhancement:request Enhancement request submitted by anyone from the community label Jul 15, 2021
@kamalkeshavani-aiinside
Copy link
Contributor Author

@junlincc Thanks for your comment. Although I don't have any experience with type script, I am hoping to get some similar fixes from other charts and re-use the code for this chart.
I am starting by looking at https://github.com/apache/superset/blob/master/CONTRIBUTING.md#improving-visualizations. I guess I can ask questions in #contributing channel in slack whenever I get stuck somewhere.

@serenajiang
Copy link
Contributor

One of our users reported a similar problem - I wonder whether this issue should be considered a bug fix rather than an enhancement request? The tooltip always uses the primary y-axis formatting even if there is a different format specified for the secondary y-axis. This is a problem for charts with very different scales (ex. proportions vs large integers).

@kevin-struckhoff
Copy link

Additionally, for single Y-axis charts, it would be helpful to allow the user to set custom grid line interval values. The attached screenshot from OpenOffice Spreadsheet shows how they handle it.
Y-axis-interval-setting

@villebro
Copy link
Member

The tooltip always uses the primary y-axis formatting even if there is a different format specified for the secondary y-axis. This is a problem for charts with very different scales (ex. proportions vs large integers).

FYI @serenajiang this problem should have been fixed by apache-superset/superset-ui#1143

@kamalkeshavani-aiinside
Copy link
Contributor Author

kamalkeshavani-aiinside commented Nov 25, 2021

  1. There should be an option to set bounds separately for both primary and secondary y-axis.
  2. There should be an option to show value labels(currently available only in Bar chart)
  3. d3 formatting set by user should be shown in tooltip for all the axis values.

2 & 3 are now fixed in master. Waiting for 1st.
And for 2nd, Y-axis values can be shown in chart, but they don't follow the formatting set by the user.
image

@apache apache locked and limited conversation to collaborators Feb 2, 2022
@geido geido converted this issue into discussion #18494 Feb 2, 2022

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
enhancement:request Enhancement request submitted by anyone from the community viz:charts:echarts Related to Echarts
Projects
None yet
Development

No branches or pull requests

6 participants