Add FQDN TCP DNS support #4612
Merged
Add FQDN TCP DNS support #4612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4612 +/- ##
==========================================
- Coverage 69.58% 68.39% -1.19%
==========================================
Files 400 403 +3
Lines 59122 60199 +1077
==========================================
+ Hits 41141 41175 +34
- Misses 15175 16169 +994
- Partials 2806 2855 +49
*This pull request uses carry forward flags. Click here to find out more.
|
GraysonWu
force-pushed
the
fqdn-tcp
branch
5 times, most recently
from
dc613c8
to
480f02e
Compare
Merged
GraysonWu
force-pushed
the
fqdn-tcp
branch
6 times, most recently
from
dbf63b3
to
7daa730
Compare
GraysonWu
force-pushed
the
fqdn-tcp
branch
6 times, most recently
from
23c8fd8
to
4e7b113
Compare
GraysonWu
force-pushed
the
fqdn-tcp
branch
4 times, most recently
from
5b59f03
to
782dec7
Compare
GraysonWu
force-pushed
the
fqdn-tcp
branch
2 times, most recently
from
2db5e01
to
de3a491
Compare
tnqn
reviewed
Mar 9, 2023
tnqn
reviewed
Mar 14, 2023
tnqn
added
the
action/release-note
|
/test-all |
|
@GraysonWu please resolve the conflict so we can merge |
1. Use tp_src=53,tcp_flags=+psh+ack to match the TCP DNS response, which can skip the handshake packets and match the packet containing the actual data. 2. To achieve 1., additional OVS fix patch should be applied. 3. While paresing TCP DNS response, we need to trim the TCP option part to retrieve the data. And while sending it out via packetOut we should construct the exact packet received by the Antrea agent. 4. Using SendEthPacketOut to send the eth packet via packetOut save us from retrieving all L2/3/4 info and make sure that we send out the packet which is exactly the same as what we received. Signed-off-by: graysonwu <wgrayson@vmware.com>
Signed-off-by: graysonwu <wgrayson@vmware.com>
|
/test-all |
Signed-off-by: graysonwu <wgrayson@vmware.com>
|
/test-all |
|
/test-multicluster-e2e |
|
/test-all |
|
/test-ipv6-only-e2e |
|
The failure in ipv6-only-e2e is not related. Tried to run it on main branch and also failed. Opened issue #4717 to track it. |
Closed
jainpulkit22
pushed a commit
to urharshitha/antrea
that referenced
this pull request
Apr 28, 2023
1. Use tp_src=53,tcp_flags=+psh+ack to match the TCP DNS response, which can skip the handshake packets and match the packet containing the actual data. 2. To achieve 1., additional OVS fix patch should be applied. 3. While paresing TCP DNS response, we need to trim the TCP option part to retrieve the data. And while sending it out via packetOut we should construct the exact packet received by the Antrea agent. 4. Using SendEthPacketOut to send the eth packet via packetOut save us from retrieving all L2/3/4 info and make sure that we send out the packet which is exactly the same as what we received. Signed-off-by: graysonwu <wgrayson@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4225
Use tp_src=53,tcp_flags=+psh+ack to match the TCP DNS response,
which can skip the handshake packets and match the packet containing
the actual data.
To achieve 1., an additional OVS fix patch should be applied.
While parsing TCP DNS response, we need to trim the TCP option
part to retrieve the data. And while sending it out via packetOut we
should construct the exact packet received by the Antrea agent.
Signed-off-by: graysonwu wgrayson@vmware.com