Update OVS to 2.17.3

[mnaser]

There are a few important bug fixes around conntrack which became available in OVS 2.17.2 so it would be good to update the image for that.

Signed-off-by: Mohammed Naser mnaser@vexxhost.com

[tnqn]

@mnaser thanks for the patch. I have a question regarding a deleted commit.

[codecov]

Codecov Report

Merging #4402 (6720e32) into main (8427b4a) will decrease coverage by 3.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4402      +/-   ##
==========================================
- Coverage   67.25%   64.12%   -3.14%     
==========================================
  Files         376      400      +24     
  Lines       54619    56887    +2268     
==========================================
- Hits        36733    36477     -256     
- Misses      15255    17808    +2553     
+ Partials     2631     2602      -29     

Flag	Coverage Δ
e2e-tests	38.32% <ø> (?)
integration-tests	34.60% <ø> (+0.05%)	⬆️
kind-e2e-tests	45.86% <ø> (-1.97%)	⬇️
unit-tests	49.25% <ø> (-1.40%)	⬇️

Impacted Files	Coverage Δ
pkg/ipfix/ipfix_intermediate.go	0.00% <0.00%> (-90.91%)	⬇️
pkg/ipfix/ipfix_collector.go	0.00% <0.00%> (-83.34%)	⬇️
pkg/flowaggregator/certificate.go	0.00% <0.00%> (-75.53%)	⬇️
pkg/flowaggregator/exporter/utils.go	0.00% <0.00%> (-72.73%)	⬇️
pkg/ipfix/ipfix_process.go	31.25% <0.00%> (-68.75%)	⬇️
pkg/flowaggregator/apiserver/apiserver.go	4.61% <0.00%> (-58.47%)	⬇️
pkg/agent/flowexporter/exporter/certificate.go	27.77% <0.00%> (-38.89%)	⬇️
pkg/controller/networkpolicy/tier.go	16.66% <0.00%> (-38.34%)	⬇️
pkg/ipfix/ipfix_registry.go	66.66% <0.00%> (-33.34%)	⬇️
pkg/flowaggregator/flowaggregator.go	36.62% <0.00%> (-31.80%)	⬇️
... and 73 more

[tnqn]

LGTM, thanks @mnaser

[tnqn]

/test-all

[gaopeiliang]

is there some explain abount ovs conntrack fix ?

[tnqn]

is there some explain abount ovs conntrack fix ?

Not sure if it's related to OVS conntrack fix, but @GraysonWu indeed met an issue with OVS 2.17.3 when he worked on #4612.
@gaopeiliang Do you have anything we should know?
@GraysonWu Do you know if 2.17.1 or 2.17.2 has that issue?

[tnqn]

Ah, it seems I misread the comment. I thought @gaopeiliang was asking whether we met issue with the ovs conntrack fix.

[gaopeiliang]

en, we have an firewall module use ct flow action (ovs conntrack, ovs 2.14), sometimes "handler_duplicate_upcall" "upcall_ukey_replace" rate very high ... and vswitchd use more CPU, kernel datapath maybe miss always ...

1. it maybe IP flow related with conntrack
2. clean and reinstall ct flow can recover it

so I want to know the case about "conntrack fix", and how 2.17.3 about stable ,,,

the commit log said less about fix case ...

[GraysonWu]

is there some explain abount ovs conntrack fix ?

Not sure if it's related to OVS conntrack fix, but @GraysonWu indeed met an issue with OVS 2.17.3 when he worked on #4612. @gaopeiliang Do you have anything we should know? @GraysonWu Do you know if 2.17.1 or 2.17.2 has that issue?

Haven't tested 2.17.1 or 2.17.2. Post the issue I met here: openvswitch/ovs-issues#272