Skip to content
This repository has been archived by the owner on Sep 19, 2024. It is now read-only.

feat: New username insertion and updation #72

Merged
merged 1 commit into from
Jul 5, 2019
Merged

feat: New username insertion and updation #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions app/src/main/java/org/amfoss/templeapp/activities/InsertData.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,11 @@ protected Void doInBackground(Void... params) {
} catch (JSONException je) {
Log.i(Controller.TAG, getString(R.string.exception) + je.getLocalizedMessage());
}
if (flag == 1) {
id = "REG";
} else {
id = "DON";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of hardcaoded Strings please use resource files

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Chromicle I guess here is fine w/o hardcoded strings too. A variable is being assigned some values. We need not use string resources for absolutely everything.

}
return null;
}

Expand Down
5 changes: 5 additions & 0 deletions app/src/main/java/org/amfoss/templeapp/activities/UpdateData.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,11 @@ protected Void doInBackground(Void... params) {
} catch (JSONException je) {
Log.i(Controller.TAG, "" + je.getLocalizedMessage());
}
if (flag == 1) {
id = "REG";
} else {
id = "DON";
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

return null;
}

Expand Down