This repository has been archived by the owner on Sep 19, 2024. It is now read-only.
feat: New username insertion and updation #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yashk2000
changed the title
yashk2000
approved these changes
Jul 4, 2019
ajay-prabhakar
suggested changes
Jul 4, 2019
| if (flag == 1) { | ||
| id = "REG"; | ||
| } else { | ||
| id = "DON"; |
There was a problem hiding this comment.
Instead of hardcaoded Strings please use resource files
There was a problem hiding this comment.
@Chromicle I guess here is fine w/o hardcoded strings too. A variable is being assigned some values. We need not use string resources for absolutely everything.
| id = "REG"; | ||
| } else { | ||
| id = "DON"; | ||
| } |
immadisairaj
approved these changes
Jul 4, 2019
ajay-prabhakar
approved these changes
Jul 5, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #49