Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

Feature/dev cdn update #138

Merged

Conversation

infoxicator
Copy link
Contributor

Updated one-app-dev-cdn to 3.3.0 and passed the use-host flag in development.

Description

Motivation and Context

This change is required for the browser tests to run properly when the one-app-dev-cdn runs inside a docker container.

How Has This Been Tested?

  • Unit tests.
  • Served locally and when passing the flag, the statics assets are served using the host (ip address) instead of localhost.
  • Inspected the browser network tab and compared when passing the flag to see if the assets loaded from the expected host or localhost.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • Performance tests should be ran against the server prior to merging.
  • This change impacts caching for client browsers.
  • This change impacts HTTP headers.
  • This change adds additional environment variable requirements for One App users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using One App?

No impact, development only

@infoxicator infoxicator requested review from a team as code owners May 13, 2020 12:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants