Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sync master #9

Merged
merged 6 commits into from
Apr 3, 2020
Merged

sync master #9

merged 6 commits into from
Apr 3, 2020

Conversation

infoxicator
Copy link
Owner

Description

Motivation and Context

How Has This Been Tested?

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • Performance tests should be ran against the server prior to merging.
  • This change impacts caching for client browsers.
  • This change impacts HTTP headers.
  • This change adds additional environment variable requirements for One App users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using One App?

Michael A Tomcal and others added 6 commits March 24, 2020 12:03
docs(server): added module map and env var docs
0b9b2b5
@Francois-Esquire
fix(provided-externals): logs warning for child modules (#32)
24a9be4 
* fix(provided-externals): logs warning for child modules

* feat(integration): add tests for required and provided externals

Co-authored-by: James Singleton <james.singleton1@aexp.com>
@JamesSingleton
chore(workflow): update stale workflow
322e989
@anescobar1991 @10xLaCroixDrinker
chore(dockerignore): add files not needed in docker image
fcc338b
@nellyk
docs(codeowners): adding default pr reviewers (#78)
71542c1
@10xLaCroixDrinker
feat(holocron): holocron 1.1.0
5e84384 
Co-authored-by: Jimmy King <jimmy.king@aexp.com>
@infoxicator infoxicator merged commit 857bb67 into infoxicator:master Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@infoxicator @Francois-Esquire @anescobar1991 @nellyk