Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Symfony Process() usage #11

Merged
merged 2 commits into from
Aug 14, 2023
Merged

Conversation

dwoods
Copy link
Contributor

@dwoods dwoods commented Feb 3, 2023

No description provided.

@dwoods
Copy link
Contributor Author

dwoods commented Feb 3, 2023

Fixes #10

@bbenesh
Copy link

bbenesh commented Feb 14, 2023

I tested this locally and it fixed my issues with lando pull on a D10 site.

@tobybellwood
Copy link
Member

I'm happy to not handle any b/c in the package - and just make this next release d9+ compatible only (as per #12).

I've not got an example set up to test d8/d9 - but I think @bbenesh might be able to check d9 with the original commit, and not worry about the fallback code?

@bbenesh
Copy link

bbenesh commented Feb 15, 2023

I checked the original commit with my local D9 demo and it worked!

@tobybellwood
Copy link
Member

Just reviewing this now, and it no longer works (with our test instance, running ssh portal/token) - will look into it

cli-drupal:/app$ drush la

In RequestException.php line 113:
                                                                                                                        
  Client error: `POST https://api.main.lagoon-core.test6.amazee.io/graphql` resulted in a `401 Unauthorized` response:  
  {"errors":[{"message":"Unauthorized - Bearer token required"}]}    

@tobybellwood
Copy link
Member

I"m going to merge this, then PR the SSH Portal fix (it's a bit picker about commands, and doesn't like being passed the token and the 2&>1 redirect, so I'll handle errors in the mustRun

@tobybellwood tobybellwood merged commit ac4d054 into amazeeio:master Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants