Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error with Drupal 10 / Symfony 6 #10

Closed
dwoods opened this issue Feb 3, 2023 · 3 comments
Closed

Error with Drupal 10 / Symfony 6 #10

dwoods opened this issue Feb 3, 2023 · 3 comments

Comments

@dwoods
Copy link
Contributor

dwoods commented Feb 3, 2023

When doing a 'lando pull' and probably other operations on a Drupal 10 site, it's throwing the following error:

Uncaught TypeError: Symfony\Component\Process\Process::__construct(): Argument #1 ($command) must be of type array, string given, called in /app/drush/Commands/contrib/drupal_integrations/src/LagoonCommands.php on line 194 and defined in /app/vendor/symfony/process/Process.php:143

It looks like Symfony Process(string) was changed to Process(array). After checking it appears this new signature was intruduced in Symfony 3.4, but recent versions must have removed the old syntax.

PR coming with a fix.

@tobybellwood
Copy link
Member

Looks like it came in symfony 4.2 - symfony/symfony#27821 - this would mean it's only available in Drupal 9 - we will need to look at how to treat any b/c

@dwoods
Copy link
Contributor Author

dwoods commented Feb 14, 2023

Updated the PR with a check for the Symfony version, I wonder if that is a good solution for b/c? Tested on D10 but not D9 or D8 yet

@tobybellwood
Copy link
Member

fixed in #11 #12 and #19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants