Skip to content
This repository has been archived by the owner on Jul 17, 2023. It is now read-only.

[#171053583] Bump UAA to v74.13.0 #15

Merged
merged 120 commits into from
Feb 12, 2020
Merged

[#171053583] Bump UAA to v74.13.0 #15

merged 120 commits into from
Feb 12, 2020

Commits on Nov 20, 2019

  1. Excluded JSON libraries from gradle

    - Because they conflict with org.json.JSONObject from SCIM libraries
    
    [#169854769]
    
    Signed-off-by: Andrew Wittrock <awittrock@pivotal.io>
    joshuatcasey authored and Birdrock committed Nov 20, 2019
    Configuration menu
    Copy the full SHA
    c346eb7 View commit details
    Browse the repository at this point in the history
  2. Test Refactor - move file from server/ to uaa/

    [#169854769]
    
    Signed-off-by: Andrew Wittrock <awittrock@pivotal.io>
    joshuatcasey authored and Birdrock committed Nov 20, 2019
    Configuration menu
    Copy the full SHA
    95580d2 View commit details
    Browse the repository at this point in the history
  3. Test Refactor - ScimUserEndpointsTests

    - Use @DefaultTestContext instead of @WithSpring
    
    [#169854769]
    
    Signed-off-by: Andrew Wittrock <awittrock@pivotal.io>
    joshuatcasey authored and Birdrock committed Nov 20, 2019
    Configuration menu
    Copy the full SHA
    9cbbc7b View commit details
    Browse the repository at this point in the history
  4. Test Refactor - move file from server/ to uaa/

    [#169854769]
    
    Signed-off-by: Andrew Wittrock <awittrock@pivotal.io>
    joshuatcasey authored and Birdrock committed Nov 20, 2019
    Configuration menu
    Copy the full SHA
    10bfd06 View commit details
    Browse the repository at this point in the history
  5. Test Refactor - remove unneeded properties

    [#169854769]
    joshuatcasey committed Nov 20, 2019
    Configuration menu
    Copy the full SHA
    ca84fd1 View commit details
    Browse the repository at this point in the history
  6. Test Refactor - UaaTokenServicesTests

    - Apply IntelliJ sanitizations
    
    [#169854769]
    joshuatcasey committed Nov 20, 2019
    Configuration menu
    Copy the full SHA
    22fcf73 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    7deb8c2 View commit details
    Browse the repository at this point in the history
  8. Replace @WithSpring with @DefaultTestContext

    [finishes #169854769]
    
    Signed-off-by: Andrew Edstrom <aedstrom@pivotal.io>
    joshuatcasey authored and andrewedstrom committed Nov 20, 2019
    Configuration menu
    Copy the full SHA
    f1a3919 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2019

  1. Test Refactor - LimitedModeUaaFilterTests

    - Apply IntelliJ suggestions and refactor
    
    [nostory]
    joshuatcasey committed Nov 21, 2019
    Configuration menu
    Copy the full SHA
    b10f53d View commit details
    Browse the repository at this point in the history
  2. Test Refactor - LimitedModeUaaFilterTests

    - Use JUnit5
    
    [nostory]
    joshuatcasey committed Nov 21, 2019
    Configuration menu
    Copy the full SHA
    4229754 View commit details
    Browse the repository at this point in the history
  3. Refactor - LimitedModeUaaFilter

    - Apply IntelliJ sanitizations
    
    [nostory]
    joshuatcasey committed Nov 21, 2019
    Configuration menu
    Copy the full SHA
    490484f View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2019

  1. Exclude logs/** in .gitignore

    [nostory]
    joshuatcasey committed Nov 27, 2019
    Configuration menu
    Copy the full SHA
    0bfa77d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9885428 View commit details
    Browse the repository at this point in the history
  3. Test Refactor - BootstrapTests uses JUnit5

    [#169991138]
    joshuatcasey committed Nov 27, 2019
    Configuration menu
    Copy the full SHA
    8cf54be View commit details
    Browse the repository at this point in the history
  4. Test Refactor - BootstrapTests

    - Use Extensions for cleanup
    
    [#169991138]
    joshuatcasey committed Nov 27, 2019
    Configuration menu
    Copy the full SHA
    0d8b8ff View commit details
    Browse the repository at this point in the history
  5. Test Refactor - BootstrapTests

    - Inline params with only one value
    
    [#169991138]
    joshuatcasey committed Nov 27, 2019
    Configuration menu
    Copy the full SHA
    964cdf4 View commit details
    Browse the repository at this point in the history
  6. Test Refactor - BootstrapTests

    - Use callbacks to reset system properties
    
    [#169991138]
    joshuatcasey committed Nov 27, 2019
    Configuration menu
    Copy the full SHA
    cec20bb View commit details
    Browse the repository at this point in the history
  7. Test Refactor - BootstrapTests

    - Inline hardcoded parameters
    
    [#169991138]
    joshuatcasey committed Nov 27, 2019
    Configuration menu
    Copy the full SHA
    9153dd7 View commit details
    Browse the repository at this point in the history
  8. Test Refactor - BootstrapTests

    - Simplify how the context is built
    
    [#169991138]
    joshuatcasey committed Nov 27, 2019
    Configuration menu
    Copy the full SHA
    72b0cb7 View commit details
    Browse the repository at this point in the history
  9. Test Refactor - BootstrapTests

    - Remove reference to non-existent file login.yml
    
    [#169991138]
    joshuatcasey committed Nov 27, 2019
    Configuration menu
    Copy the full SHA
    90d0c7d View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    a6d578b View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2019

  1. Configuration menu
    Copy the full SHA
    97b7344 View commit details
    Browse the repository at this point in the history
  2. Purge expired session from in memory map

    Prior to this commit, configuring the UAA to manage sessions in memory
    resulted in the use of `MapSessionRepository` to manage sessions.
    `MapSessionRepository` does not automatically remove expired sessions
    from it's backing map.
    
    And neither did the UAA, resulting in a memory leak.
    
    Now, register a scheduled task to remove expired sessions. The tasks
    frequency can be configured via the `servlet.session-purge-delay`
    property.
    
    [#170035178]
    shamus authored and cf-uaa committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    a048161 View commit details
    Browse the repository at this point in the history
  3. Merge pull request cloudfoundry#1152 from cloudfoundry/bugs/purge-exp…

    …ired-sessions-170035178
    
    Purge expired session from in memory map
    Jeremy Morony authored Dec 2, 2019
    Configuration menu
    Copy the full SHA
    7311e68 View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2019

  1. Add DB index on revocable tokens

    Signed-off-by: Florian Tack <florian.tack@sap.com>
    phschon authored and tack-sap committed Dec 3, 2019
    Configuration menu
    Copy the full SHA
    95e94b5 View commit details
    Browse the repository at this point in the history
  2. Bump spring-framework-bom from 5.2.1.RELEASE to 5.2.2.RELEASE

    Bumps [spring-framework-bom](https://github.com/spring-projects/spring-framework) from 5.2.1.RELEASE to 5.2.2.RELEASE.
    - [Release notes](https://github.com/spring-projects/spring-framework/releases)
    - [Commits](spring-projects/spring-framework@v5.2.1.RELEASE...v5.2.2.RELEASE)
    
    Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
    dependabot-preview[bot] authored Dec 3, 2019
    Configuration menu
    Copy the full SHA
    9f5af96 View commit details
    Browse the repository at this point in the history
  3. Merge pull request cloudfoundry#1153 from cloudfoundry/dependabot/gra…

    …dle/org.springframework-spring-framework-bom-5.2.2.RELEASE
    dependabot-preview[bot] authored Dec 3, 2019
    Configuration menu
    Copy the full SHA
    5834069 View commit details
    Browse the repository at this point in the history
  4. Test Refactor - IdentityZoneResolvingFilterTests

    - Apply IntelliJ sanitizations
    
    [#170083097]
    joshuatcasey committed Dec 3, 2019
    Configuration menu
    Copy the full SHA
    334c870 View commit details
    Browse the repository at this point in the history
  5. Test Refactor - IdentityZoneResolvingFilterTests

    - Use WithDatabaseContext
    - Use JUnit5
    
    [#170083097]
    joshuatcasey committed Dec 3, 2019
    Configuration menu
    Copy the full SHA
    a76e5a5 View commit details
    Browse the repository at this point in the history
  6. Test Refactor - UserInfoTableTest

    - Apply IntelliJ sanitizations
    
    [#170083097]
    joshuatcasey committed Dec 3, 2019
    Configuration menu
    Copy the full SHA
    47717cc View commit details
    Browse the repository at this point in the history
  7. Test Refactor - UserInfoTableTest

    - Use WithDatabaseContext
    - Use JUnit5
    
    [#170083097]
    joshuatcasey committed Dec 3, 2019
    Configuration menu
    Copy the full SHA
    e061513 View commit details
    Browse the repository at this point in the history
  8. Test Refactor - TableAndColumnNormalizationTest

    - Apply IntelliJ sanitizations
    
    [#170083097]
    joshuatcasey committed Dec 3, 2019
    Configuration menu
    Copy the full SHA
    46163bb View commit details
    Browse the repository at this point in the history
  9. Test Refactor - TableAndColumnNormalizationTest

    - Can't use WithDatabaseContext
    - Has custom Spring context :(
    - Use JUnit5
    
    [#170083097]
    joshuatcasey committed Dec 3, 2019
    Configuration menu
    Copy the full SHA
    45ea7ec View commit details
    Browse the repository at this point in the history
  10. Test Refactor - IdentityProviderBootstrapTest

    - Apply IntelliJ sanitizations
    
    [#170083097]
    joshuatcasey committed Dec 3, 2019
    Configuration menu
    Copy the full SHA
    8d4122e View commit details
    Browse the repository at this point in the history
  11. Test Refactor - JdbcMfaProviderProvisioningTest

    - Apply IntelliJ sanitizations
    
    [#170083097]
    joshuatcasey committed Dec 3, 2019
    Configuration menu
    Copy the full SHA
    e162c3a View commit details
    Browse the repository at this point in the history
  12. Test Refactor - JdbcMfaProviderProvisioningTest

    - Use WithDatabaseContext
    - Use JUnit5
    
    [#170083097]
    joshuatcasey committed Dec 3, 2019
    Configuration menu
    Copy the full SHA
    02386f9 View commit details
    Browse the repository at this point in the history
  13. Test Refactor - LimitSqlAdapterTests

    - Apply IntelliJ sanitizations
    
    [#170083097]
    joshuatcasey committed Dec 3, 2019
    Configuration menu
    Copy the full SHA
    18b2b19 View commit details
    Browse the repository at this point in the history
  14. Test Refactor - LimitSqlAdapterTests

    - Use WithDatabaseContext
    - Use JUnit5
    
    [#170083097]
    joshuatcasey committed Dec 3, 2019
    Configuration menu
    Copy the full SHA
    dc55e0d View commit details
    Browse the repository at this point in the history
  15. Test Refactor - ScimExternalGroupBootstrapTests

    - Apply IntelliJ sanitizations
    - Also remove unused import from IdentityZoneResolvingFilterTests
    
    [#170083097]
    joshuatcasey committed Dec 3, 2019
    Configuration menu
    Copy the full SHA
    5babeb4 View commit details
    Browse the repository at this point in the history
  16. Test Refactor - ScimExternalGroupBootstrapTests

    - Use WithDatabaseContext
    - Use JUnit5
    
    [#170083097]
    joshuatcasey committed Dec 3, 2019
    Configuration menu
    Copy the full SHA
    5b56438 View commit details
    Browse the repository at this point in the history
  17. Test Refactor - UaaTokenStoreTests

    - Apply IntelliJ sanitizations
    
    [#170083097]
    joshuatcasey committed Dec 3, 2019
    Configuration menu
    Copy the full SHA
    cfad970 View commit details
    Browse the repository at this point in the history
  18. Test Refactor - UaaTokenStoreTests

    - Use WithDatabaseContext
    - Use JUnit5
    
    [#170083097]
    joshuatcasey committed Dec 3, 2019
    Configuration menu
    Copy the full SHA
    348990f View commit details
    Browse the repository at this point in the history
  19. Test Refactor - ClientDetailsHasRequiredUserScopes

    - Turns out this class wasn't Parameterized
    - Hardcode all the parameterized stuff
    - Apply IntelliJ sanitizations
    
    [#170083097]
    joshuatcasey committed Dec 3, 2019
    Configuration menu
    Copy the full SHA
    fad5ca9 View commit details
    Browse the repository at this point in the history
  20. Test Refactor - ClientDetailsHasRequiredUserScopes

    - Use WithDatabaseContext
    - Use JUnit5
    
    [#170083097]
    joshuatcasey committed Dec 3, 2019
    Configuration menu
    Copy the full SHA
    db53df7 View commit details
    Browse the repository at this point in the history
  21. Test Refactor - OauthCodeIndexTest

    - Apply IntelliJ sanitizations
    
    [#170083097]
    joshuatcasey committed Dec 3, 2019
    Configuration menu
    Copy the full SHA
    c095173 View commit details
    Browse the repository at this point in the history
  22. Test Refactor - OauthCodeIndexTest

    - Use WithDatabaseContext
    - Use JUnit5
    - Turns out there's only one @test method. Parameterize it instead of the class
    
    [#170083097]
    joshuatcasey committed Dec 3, 2019
    Configuration menu
    Copy the full SHA
    54fa6d8 View commit details
    Browse the repository at this point in the history
  23. Test Refactor - StoreSubDomainAsLowerCase_V2_7_3_Tests

    - Apply IntelliJ sanitizations
    - Make methods static if they can be static
    
    [#170083097]
    joshuatcasey committed Dec 3, 2019
    Configuration menu
    Copy the full SHA
    07f6b47 View commit details
    Browse the repository at this point in the history
  24. Test Refactor - StoreSubDomainAsLowerCase_V2_7_3_Tests

    - Use @WithDatabaseContext
    - Use JUnit5
    
    [#170083097]
    joshuatcasey committed Dec 3, 2019
    Configuration menu
    Copy the full SHA
    0d861df View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2019

  1. Configuration menu
    Copy the full SHA
    5da47a0 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2019

  1. use source compatibility in parent project instead

    Signed-off-by: Fan Shang Xiang <fanshangxiang@gmail.com>
    MartinForReal authored and Birdrock committed Dec 5, 2019
    Configuration menu
    Copy the full SHA
    0eea797 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    86a286f View commit details
    Browse the repository at this point in the history
  3. Fix test broken by pollution

    [nostory]
    
    Signed-off-by: Andrew Wittrock <awittrock@pivotal.io>
    andrewedstrom authored and Birdrock committed Dec 5, 2019
    Configuration menu
    Copy the full SHA
    5e16631 View commit details
    Browse the repository at this point in the history
  4. Test refactor - ClientInfoEndpointTests

    - Bump to Junit5
    - Stop using init block for setup
    - Generally prettify
    
    Signed-off-by: Andrew Wittrock <awittrock@pivotal.io>
    andrewedstrom authored and Birdrock committed Dec 5, 2019
    Configuration menu
    Copy the full SHA
    0f86a5a View commit details
    Browse the repository at this point in the history
  5. Refactor - ClientInfoEndpoint uses IdentityZoneManager

    Signed-off-by: Andrew Wittrock <awittrock@pivotal.io>
    andrewedstrom authored and Birdrock committed Dec 5, 2019
    Configuration menu
    Copy the full SHA
    8fe4fa6 View commit details
    Browse the repository at this point in the history
  6. Using ./gradlew run now uses ROOT context path

    - Unit tests pass
    
    [#170107012]
    joshuatcasey committed Dec 5, 2019
    Configuration menu
    Copy the full SHA
    46c4762 View commit details
    Browse the repository at this point in the history
  7. Run UAA at ROOT context - Fix TokenEndpointDocs

    [#170107012]
    joshuatcasey committed Dec 5, 2019
    Configuration menu
    Copy the full SHA
    e292390 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2019

  1. Merge pull request cloudfoundry#1154 from phschon/revocaable_tokens

    Add DB index on revocable tokens table
    strehle authored Dec 6, 2019
    Configuration menu
    Copy the full SHA
    95aaa3f View commit details
    Browse the repository at this point in the history
  2. Revert "Run UAA at ROOT context - Fix TokenEndpointDocs"

    This reverts commit e292390.
    cf-uaa committed Dec 6, 2019
    Configuration menu
    Copy the full SHA
    9c1f29d View commit details
    Browse the repository at this point in the history
  3. Revert "Using ./gradlew run now uses ROOT context path"

    This reverts commit 46c4762.
    cf-uaa committed Dec 6, 2019
    Configuration menu
    Copy the full SHA
    65952b1 View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2019

  1. Bump versions.springBootVersion from 2.2.1.RELEASE to 2.2.2.RELEASE

    Bumps `versions.springBootVersion` from 2.2.1.RELEASE to 2.2.2.RELEASE.
    
    Updates `spring-boot-dependencies` from 2.2.1.RELEASE to 2.2.2.RELEASE
    - [Release notes](https://github.com/spring-projects/spring-boot/releases)
    - [Commits](spring-projects/spring-boot@v2.2.1.RELEASE...v2.2.2.RELEASE)
    
    Updates `spring-boot-gradle-plugin` from 2.2.1.RELEASE to 2.2.2.RELEASE
    - [Release notes](https://github.com/spring-projects/spring-boot/releases)
    - [Commits](spring-projects/spring-boot@v2.2.1.RELEASE...v2.2.2.RELEASE)
    
    Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
    dependabot-preview[bot] authored Dec 9, 2019
    Configuration menu
    Copy the full SHA
    c48cbee View commit details
    Browse the repository at this point in the history
  2. Merge pull request cloudfoundry#1158 from cloudfoundry/dependabot/gra…

    …dle/versions.springBootVersion-2.2.2.RELEASE
    dependabot-preview[bot] authored Dec 9, 2019
    Configuration menu
    Copy the full SHA
    cbb302c View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2019

  1. reintroduce set-version.sh script

    [#169720342]
    
    Signed-off-by: Stephane Jolicoeur <sjolicoeur@pivotal.io>
    Co-authored-by: Stephane Jolicoeur <sjolicoeur@pivotal.io>
    andrewedstrom and sjolicoeur committed Dec 10, 2019
    Configuration menu
    Copy the full SHA
    3aed665 View commit details
    Browse the repository at this point in the history
  2. data-source configuration

    add more properties to dynamic configuration.
    Set default for new properties
    strehle committed Dec 10, 2019
    Configuration menu
    Copy the full SHA
    020398f View commit details
    Browse the repository at this point in the history
  3. Minimal server.xml for UAA image

    This server.xml should represent the minimal configuration necessary for
    the UAA to successfully run. Tomcat behavior cannot be configured yet
    and logging will go to the console for now.
    
    Configuration of the UAA, however, is possible by providing the location
    of the UAA config file via one of the supported environment variables.
    
    [#169713142]
    
    Signed-off-by: Jeremy Morony <jmorony@pivotal.io>
    andrewedstrom authored and Jeremy Morony committed Dec 10, 2019
    Configuration menu
    Copy the full SHA
    2b01747 View commit details
    Browse the repository at this point in the history
  4. Merge pull request cloudfoundry#1162 from cloudfoundry/features/uaa-i…

    …mage-169713142
    
    Minimal server.xml for UAA image
    andrewedstrom authored Dec 10, 2019
    Configuration menu
    Copy the full SHA
    9dd2f1a View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2019

  1. Bump org.eclipse.jgit from 5.5.1.201910021850-r to 5.6.0.201912101111-r

    Bumps org.eclipse.jgit from 5.5.1.201910021850-r to 5.6.0.201912101111-r.
    
    Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
    dependabot-preview[bot] authored Dec 11, 2019
    Configuration menu
    Copy the full SHA
    14aa78a View commit details
    Browse the repository at this point in the history
  2. Merge pull request cloudfoundry#1163 from cloudfoundry/dependabot/gra…

    …dle/org.eclipse.jgit-org.eclipse.jgit-5.6.0.201912101111-r
    dependabot-preview[bot] authored Dec 11, 2019
    Configuration menu
    Copy the full SHA
    6478d41 View commit details
    Browse the repository at this point in the history
  3. Add logging to YamlServletProfileInitializer

    - To make it easier to know what's happening in K8s
    
    [#169718245]
    
    Signed-off-by: Joshua Casey <jcasey@pivotal.io>
    sjolicoeur authored and joshuatcasey committed Dec 11, 2019
    Configuration menu
    Copy the full SHA
    447940c View commit details
    Browse the repository at this point in the history
  4. Add K8s Deployment Manifest

    - Deploys a pinned identity/uaa image digest
    - No templating / configuration options (yet)
    
    [#169718245]
    
    Signed-off-by: Joshua Casey <jcasey@pivotal.io>
    Co-authored-by: Joshua Casey <jcasey@pivotal.io>
    2 people authored and cf-uaa committed Dec 11, 2019
    Configuration menu
    Copy the full SHA
    4fc481d View commit details
    Browse the repository at this point in the history
  5. Do not report tomcat internals in access logs

    [#170193262]
    
    Signed-off-by: Andrew Wittrock <awittrock@pivotal.io>
    Jeremy Morony authored and Birdrock committed Dec 11, 2019
    Configuration menu
    Copy the full SHA
    267d764 View commit details
    Browse the repository at this point in the history
  6. Named the service port for istio compatibility

    - renamed the service
    
    [#169718451]
    
    Signed-off-by: Joshua Casey <jcasey@pivotal.io>
    Co-authored-by: Joshua Casey <jcasey@pivotal.io>
    2 people authored and cf-uaa committed Dec 11, 2019
    Configuration menu
    Copy the full SHA
    aa6b9e6 View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2019

  1. Temporarily ignoring test blocking story delivery.

    - Test is unrelated to stories needing delivery.
    - Ignoring PostgresDbMigrationIntegrationTest > mfaTableAddsTwoNewColumns.
    
    [nostory]
    
    Signed-off-by: Andrew Wittrock <awittrock@pivotal.io>
    Jeremy Morony committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    045325a View commit details
    Browse the repository at this point in the history
  2. Revert "Temporarily ignoring test blocking story delivery."

    This reverts commit 045325a.
    Jeremy Morony committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    a98c9f3 View commit details
    Browse the repository at this point in the history
  3. Refactor - YamlServletProfileInitializer

    - Use Java Set directly instead of parsing a hardcoded string
    
    [#170136573]
    joshuatcasey committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    41e1ee9 View commit details
    Browse the repository at this point in the history
  4. Refactor - YamlServletProfileInitializer

    - Use Streams and Lambdas over imperative
    - Also - last commit did not preserve order!
    
    [#170136573]
    joshuatcasey committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    ed9b709 View commit details
    Browse the repository at this point in the history
  5. Refactor - YamlServletProfileInitializer

    - Use newlines to make string legible
    
    [#170136573]
    joshuatcasey committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    340c628 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2019

  1. Refactor - YamlServletProfileInitializer

    - Pull Locations into static final
    - Because it doesn't change
    
    [#170136573]
    joshuatcasey committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    5b9a55b View commit details
    Browse the repository at this point in the history
  2. Hardcode reference to env var UAA_CONFIG_YAML

    - There's no way to change or set it
    
    [#170136573]
    joshuatcasey committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    0bed300 View commit details
    Browse the repository at this point in the history
  3. Fix postgres migration test failure

    Using `CREATE INDEX CONCURRENTLY` in our new migration causes flyway to
    automatically run the migration in `autocommit` mode.
    `connection.commit()` is only supposed to be called when autocommit mode
    is off.
    
    This change makes our migration test runner able to handle migrations
    that run in `autocommit` mode.
    
    [#169775896]
    
    Signed-off-by: Andrew Edstrom <aedstrom@pivotal.io>
    Co-authored-by: Andrew Edstrom <aedstrom@pivotal.io>
    Signed-off-by: Andrew Edstrom <aedstrom@pivotal.io>
    joshuatcasey and andrewedstrom committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    480760e View commit details
    Browse the repository at this point in the history
  4. Refactor - autoformat HomeController

    [nostory]
    joshuatcasey committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    5b9b4f6 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    3c07ab5 View commit details
    Browse the repository at this point in the history
  6. Refactor - SamlServiceProviderEndpoints

    - Use inline @qualifier instead of XML definition
    
    [nostory]
    joshuatcasey committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    c4013af View commit details
    Browse the repository at this point in the history
  7. Refactor - @ContextConfiguration

    - spring/env.xml works just fine
    - list can end with ","
    
    [nostory]
    joshuatcasey committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    1817c51 View commit details
    Browse the repository at this point in the history
  8. Refactor - YamlServletProfileInitializer

    - Remove Dead Code
    - Not a behavioral change!
    - ${APPLICATION_CONFIG_URL} and file:${APPLICATION_CONFIG_FILE} would never be checked because the ternary would shortcircuit to true
    - resources.isEmpty() would always be false because classpath:uaa.yml always exists
    
    [#170136573]
    joshuatcasey committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    a4b9391 View commit details
    Browse the repository at this point in the history
  9. Refactor - YamlServletProfileInitializer

    - Use collections and streams instead of CSV and imperative
    
    [#170136573]
    joshuatcasey committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    045b0d7 View commit details
    Browse the repository at this point in the history
  10. Test Refactor - remove unnecessary @configuration

    - @configuration annotation is unnecessary when the class is brought into the Spring Context using @ContextConfiguration
    
    [#170295071]
    joshuatcasey committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    c25774e View commit details
    Browse the repository at this point in the history
  11. Refactor - EncryptionKeyService

    - Inline @value for cleaner XML
    
    [nostory]
    joshuatcasey committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    af44d37 View commit details
    Browse the repository at this point in the history
  12. Refactor - autoformat AccountsController

    [nostory]
    joshuatcasey committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    86c0db4 View commit details
    Browse the repository at this point in the history
  13. Refactor - Remove duplicated @bean Definition

    - AccountsController will be brought into the context already via component-scan on line https://github.com/cloudfoundry/uaa/blob/c25774eac882f6c78855f9a56632b2d2bae4add2/server/src/main/resources/spring/login-ui.xml#L516
    
    [nostory]
    joshuatcasey committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    5516e22 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2019

  1. Test Refactor - Clean up Test Setup

    - Because this will make it easier to Boot
    
    [nostory]
    joshuatcasey committed Dec 14, 2019
    Configuration menu
    Copy the full SHA
    0a75751 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2019

  1. Configuration menu
    Copy the full SHA
    b8eea4e View commit details
    Browse the repository at this point in the history
  2. Merge pull request cloudfoundry#1168 from cloudfoundry/dependabot/gra…

    …dle/com.bmuschko-gradle-cargo-plugin-2.6.2
    dependabot-preview[bot] authored Dec 16, 2019
    Configuration menu
    Copy the full SHA
    2ed9e48 View commit details
    Browse the repository at this point in the history
  3. Cleanup XML files

    - Remove Copyright notices
    - Put in Test dir if applicable
    
    [nostory]
    joshuatcasey committed Dec 16, 2019
    Configuration menu
    Copy the full SHA
    d389592 View commit details
    Browse the repository at this point in the history
  4. Cleanup - move files to test instead of main

    [nostory]
    joshuatcasey committed Dec 16, 2019
    Configuration menu
    Copy the full SHA
    45e6f21 View commit details
    Browse the repository at this point in the history
  5. Use Global component-scan

    - Simplify XML files
    - Prep for Spring Boot
    
    [#170299042]
    joshuatcasey committed Dec 16, 2019
    Configuration menu
    Copy the full SHA
    b51b55a View commit details
    Browse the repository at this point in the history
  6. Fix Integration Test

    - https://hush-house.pivotal.io/teams/cf-uaa/pipelines/uaa-acceptance-gcp/jobs/integration-tests-mysql/builds/36
    - One test creates a group that's deleted in the @after, meaning that the group is deleted three times
    - Something related to b51b55a means that no longer works, but it shouldn't have worked anyways
    
    [nostory]
    joshuatcasey committed Dec 16, 2019
    Configuration menu
    Copy the full SHA
    4441247 View commit details
    Browse the repository at this point in the history
  7. Refactor - apply IntelliJ sanitizations

    [nostory]
    joshuatcasey committed Dec 16, 2019
    Configuration menu
    Copy the full SHA
    0a80235 View commit details
    Browse the repository at this point in the history
  8. Test Refactor - UaaMetricsFilterTests

    - Use JUnit5
    
    [nostory]
    joshuatcasey committed Dec 16, 2019
    Configuration menu
    Copy the full SHA
    0c816f2 View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2019

  1. Refactor - UaaMetricsFilter

    - Required properties should be put in the constructor
    
    [nostory]
    joshuatcasey committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    5f9cb54 View commit details
    Browse the repository at this point in the history
  2. Refactor - UaaMetricsFilter

    - Use TimeServiceBean
    - Mark internals as final and init them in c'tor
    
    [nostory]
    joshuatcasey committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    6c1eaca View commit details
    Browse the repository at this point in the history
  3. Test Refactor - XFrameOptionsTheories

    - Use @DefaultTestContext
    
    [nostory]
    joshuatcasey committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    cb88cf2 View commit details
    Browse the repository at this point in the history
  4. Test Refactor - PollutionPreventionExtensionTests

    - Use @DefaultTestContext
    
    [nostory][
    joshuatcasey committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    105dbb0 View commit details
    Browse the repository at this point in the history
  5. Test Refactor - DefaultTestContext

    - Bring helper classes into same file
    - Reinforces that @DefaultTestContext is what to use
    
    [nostory]
    joshuatcasey committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    9c6aeaa View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    0d05005 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2019

  1. Bump rack from 2.0.1 to 2.0.8 in /uaa/slate

    Bumps [rack](https://github.com/rack/rack) from 2.0.1 to 2.0.8.
    - [Release notes](https://github.com/rack/rack/releases)
    - [Changelog](https://github.com/rack/rack/blob/master/CHANGELOG.md)
    - [Commits](rack/rack@2.0.1...2.0.8)
    
    Signed-off-by: dependabot[bot] <support@github.com>
    dependabot[bot] authored and joshuatcasey committed Dec 19, 2019
    Configuration menu
    Copy the full SHA
    ef343b9 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2019

  1. allow wildcard in port (cloudfoundry#1140)

    * allow wildcard in port
    
    - during URI normalize the port wildcard info is lost and then laster in match it fails
    - check therefore only for clientRedirect if port is wildcard and store the info
    - in match adjust URis with port wildcard
    
    * test for default port
    
    * do not match if default port
    
    * remove space
    strehle authored Dec 20, 2019
    Configuration menu
    Copy the full SHA
    afdc83b View commit details
    Browse the repository at this point in the history

Commits on Dec 27, 2019

  1. Bump guava from 28.1-jre to 28.2-jre

    Bumps [guava](https://github.com/google/guava) from 28.1-jre to 28.2-jre.
    - [Release notes](https://github.com/google/guava/releases)
    - [Commits](https://github.com/google/guava/commits)
    
    Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
    dependabot-preview[bot] authored Dec 27, 2019
    Configuration menu
    Copy the full SHA
    bfc4769 View commit details
    Browse the repository at this point in the history
  2. Merge pull request cloudfoundry#1176 from cloudfoundry/dependabot/gra…

    …dle/com.google.guava-guava-28.2-jre
    dependabot-preview[bot] authored Dec 27, 2019
    Configuration menu
    Copy the full SHA
    ee38c55 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2e294df View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2020

  1. Configuration menu
    Copy the full SHA
    5debb20 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    65db74d View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2020

  1. Do not report tomcat internals in error messages

    We put the Valve in the wrong spot in our first attempt.
    
    Coincidentally, since then the same change was made in the tomcat-cnb's
    server.xml: https://github.com/cloudfoundry/tomcat-cnb/blob/8ef1890ae95ad5a84adb288bd7cb739001bdcb96/server.xml#L31
    
    [#170193262]
    
    Signed-off-by: Andrew Edstrom <aedstrom@pivotal.io>
    Co-authored-by: Andrew Edstrom <aedstrom@pivotal.io>
    Birdrock and andrewedstrom committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    ea4693f View commit details
    Browse the repository at this point in the history
  2. Format server.xml to match tomcat-cnb's server.xml

    We want to keep these two as in-sync as possible: https://github.com/cloudfoundry/tomcat-cnb/blob/master/server.xml
    
    [#170193262]
    
    Signed-off-by: Andrew Edstrom <aedstrom@pivotal.io>
    Co-authored-by: Andrew Edstrom <aedstrom@pivotal.io>
    Birdrock and andrewedstrom committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    afa7854 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2020

  1. Template testing support.

    This commit provides a set of matchers to facilitate
    - shelling out to YTT to generate k8s templates as
    - parsing the resulting yaml into k8s API structs
    - matchers for interacting with those structs.
    
    [#169718758]
    
    Signed-off-by: Joshua Casey <jcasey@pivotal.io>
    andrewedstrom authored and joshuatcasey committed Jan 10, 2020
    Configuration menu
    Copy the full SHA
    40224fc View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2020

  1. Add Makefile for K8s template rendering

    - Includes running the template tests in Go
    
    [#169718758]
    
    Signed-off-by: Joshua Casey <jcasey@pivotal.io>
    Jeremy Morony committed Jan 11, 2020
    Configuration menu
    Copy the full SHA
    2b5f6a8 View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2020

  1. Touch templates/values/values.yml

    This file is required for the tests to pass.
    shamus committed Jan 12, 2020
    Configuration menu
    Copy the full SHA
    1a45483 View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2020

  1. Refactor matchers.

    Bringing the matchers closer to the underlying structure of the parsed
    YAML. This should ease both the extension of the matchers and their
    expressiveness.
    shamus committed Jan 13, 2020
    Configuration menu
    Copy the full SHA
    f6ef8bc View commit details
    Browse the repository at this point in the history
  2. Merge pull request cloudfoundry#1181 from cloudfoundry/chores/matcher…

    …-cleanup
    
    Chores/matcher cleanup
    andrewedstrom authored Jan 13, 2020
    Configuration menu
    Copy the full SHA
    9ccfc69 View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2020

  1. Implement multiple modes of issuer claim validation

    Some IDPs (e.g. Microsoft) create tokens whose `iss` claim can vary from user
    to user. Under the current version, UAA was unable to integrate with these
    providers because it requires a single, specific issuer value to be present.
    
    To enable UAA to integrate with providers who do this, we implement different
    modes for validating the `iss` claim, under the `issuerValidationMode`
    configuration property for OIDC providers
    
    The modes are
    
    STRICT
      The default behaviour. The string in the `iss` claim and the configured
      issuer URL must match exactly.
    
    DOMAIN_ONLY
      The value of the `iss` claim and the configured issuer URL must be URLs. They
      are considered to match if their domains match. Subdomains are not considered
      to match a parent domain.
    AP-Hunt authored and mogds committed Feb 10, 2020
    Configuration menu
    Copy the full SHA
    939b15d View commit details
    Browse the repository at this point in the history
  2. Do not expire invitations on GET requests

    At the moment, when the user visits:
    
    ```
    /invitations/accept?code=some-code
    ```
    
    the invitation code from their email is immediately expired and replaced
    with a newly generated code which is put in a hidden input in the HTML
    form. Each time the user submits the form, the code is expired and (if
    necessary - e.g. if there's a validation issue) replaced with a new one.
    
    This is fine so long as the user fills the form in immediately, but
    there are a number of edge cases where this approach causes usability
    problems:
    
    1) If the user refreshes the page it will tell them their invitation has
       expired.
    2) If the user closes the tab without submitting the form, and then
       follows the invitation link from their email later it will show as
       expired.
    3) If the user's email client or web browser pre-fetches the link for
       any reason (e.g. virus scanning / spam detection / performance
       optimisation) then the link will not work when they follow it for
       real.
    
    The third issue is the most serious.
    
    We (GOV.UK PaaS) have had some very users working in places that
    pre-fetch links in emails (for some reason or other), and this means
    they're completely unable to accept invitations. Judging from the irate
    support tickets we've had from these users the experience is pretty
    frustrating.
    
    This commit changes the GET request to /invitations/accept so that it
    does not expire the token (unless the invitation is being auto-accepted).
    
    The POST handler is unchanged, so if the user actually submits the form
    then the token will change (as it did before), even if there's a
    validation issue that prevents the invitation being accepted.
    
    This change fixes the usability issues, and makes the behaviour more
    consistent with HTTP's semantics (in the sense that GET requests should
    be "safe" - should not modify the state of the server).
    richardTowers authored and mogds committed Feb 10, 2020
    Configuration menu
    Copy the full SHA
    ecff013 View commit details
    Browse the repository at this point in the history