Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimal server.xml for UAA image #1162

Merged
merged 1 commit into from
Dec 10, 2019
Merged

Conversation

shamus
Copy link
Contributor

@shamus shamus commented Dec 10, 2019

This server.xml should represent the minimal configuration necessary for the UAA to successfully run. Tomcat behavior cannot be configured yet and logging will go to the console for now.

Configuration of the UAA, however, is possible by providing the location of the UAA config file via one of the supported environment variables.

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/170216541

The labels on this github issue will be updated when the story is started.

Copy link
Contributor

@andrewedstrom andrewedstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. By design it's very similar to https://github.com/cloudfoundry/tomcat-cnb/blob/master/server.xml, and the ways it diverges seem reasonable

Follow these steps to actually use it in the pack CLI: https://www.pivotaltracker.com/story/show/169713142/comments/209546135

@strehle
Copy link
Member

strehle commented Dec 10, 2019

@shamus can you please check PR
cloudfoundry/uaa-release#108
and add also

    <Valve className="org.apache.catalina.valves.ErrorReportValve"
           showReport="false"
           showServerInfo="false"/>

so that failures do not show the stacktrace

@andrewedstrom
Copy link
Contributor

@strehle we have a separate story for that valve. Linking so you can follow along: https://www.pivotaltracker.com/story/show/170193262

This server.xml should represent the minimal configuration necessary for
the UAA to successfully run. Tomcat behavior cannot be configured yet
and logging will go to the console for now.

Configuration of the UAA, however, is possible by providing the location
of the UAA config file via one of the supported environment variables.

[#169713142]

Signed-off-by: Jeremy Morony <jmorony@pivotal.io>
@shamus shamus force-pushed the features/uaa-image-169713142 branch from acdf6ee to 2b01747 Compare December 10, 2019 20:18
@andrewedstrom andrewedstrom merged commit 9dd2f1a into develop Dec 10, 2019
@shamus
Copy link
Contributor Author

shamus commented Dec 10, 2019

@strehle Something that isn't immediately clear from @andrewedstrom's message is we're taking this opportunity to do a bit of housecleaning while doing this k8s work. So we're looking to start with minimal & build up as we introduce features into the k8s release.

We appreciate the feedback and please keep it coming! We don't want to accidentally cut anything important.

@cf-gitbot cf-gitbot added in progress accepted Accepted the issue and removed in progress labels Dec 10, 2019
@shamus shamus deleted the features/uaa-image-169713142 branch January 13, 2020 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Accepted the issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants