Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add custom dimension to segment page views by Brexit audience type #2186

Merged
merged 5 commits into from
Jul 5, 2021
Merged

Add custom dimension to segment page views by Brexit audience type #2186

merged 5 commits into from
Jul 5, 2021

Commits on Jul 5, 2021

  1. Remove custom dimension from breadcrumb clicks 

    - We want to use custom dimension 111 to segment page views by audience.
Removing the dimension from clicks to the superbreadcrumbs at request of
PA colleagues.

Reverts #6cc2f437
    @hannako
    hannako committed Jul 5, 2021
    Configuration menu
    Copy the full SHA
    1fd9328 View commit details
    Browse the repository at this point in the history

  2. Small refactor 

    - We need to know the brexit audience for CD tracking. Renaming
this method before we make it public.
    @hannako
    hannako committed Jul 5, 2021
    Configuration menu
    Copy the full SHA
    aa3b0ad View commit details
    Browse the repository at this point in the history

  3. Expose the brexit audience type 

    - We are returning "Brexitbusinessandcitizen" when a page is tagged
to BOTH child taxons, or ONLY the brexit parent taxon. This is deliberate
and a request from our PA.
    @hannako
    hannako committed Jul 5, 2021
    Configuration menu
    Copy the full SHA
    c5b8654 View commit details
    Browse the repository at this point in the history

  4. Add custom dimension 111 to page views 

    Store the brexit audience type in custom dimension 111.
    @hannako
    hannako committed Jul 5, 2021
    Configuration menu
    Copy the full SHA
    d01822a View commit details
    Browse the repository at this point in the history

  5. Update changelog

    @hannako
    hannako committed Jul 5, 2021
    Configuration menu
    Copy the full SHA
    24527a4 View commit details
    Browse the repository at this point in the history