Add custom dimension to segment page views by Brexit audience type #2186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- We want to use custom dimension 111 to segment page views by audience. Removing the dimension from clicks to the superbreadcrumbs at request of PA colleagues. Reverts #6cc2f437
- We need to know the brexit audience for CD tracking. Renaming this method before we make it public.
- We are returning "Brexitbusinessandcitizen" when a page is tagged to BOTH child taxons, or ONLY the brexit parent taxon. This is deliberate and a request from our PA.
Store the brexit audience type in custom dimension 111.
chao-xian
approved these changes
Jul 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
Request from PA
Visual Changes
No visual changes