Remove unnecessary duplicated use of govuk-font

[owenatgov]

What/Why

Remove instances of when our components are using govuk-font more than once when they don't need to.

Fixes #4242. More details in the issue.

Notes

At time of writing, building main locally produces minified CSS of 123kb and a CSS map of 408kb. Building this branch locally produces minified CSS of 117kb and a CSS map of 397kb.

The only 2 components that still have more than one use of govuk-font are the header and input component. Both of these are because of user agent styles that override the inherited font size, weight and font family. Specifically the button element that govuk-header__menu-button is using and the input for govuk-input.

This change makes the following classes redundant:

• govuk-panel__body
• govuk-table__caption--s

Should we deprecate these classes?

This change additionally adds our default text colour to govuk-summary-card which was missed when we initially launched this.

[github-actions]

📋 Stats

File sizes

File	Size
dist/govuk-frontend-4.6.0.min.css	118.07 KiB
dist/govuk-frontend-4.6.0.min.js	47.1 KiB
dist/govuk-frontend-ie8-4.6.0.min.css	79.27 KiB
packages/govuk-frontend/dist/govuk/all.bundle.js	77.65 KiB
packages/govuk-frontend/dist/govuk/all.bundle.mjs	72.94 KiB
packages/govuk-frontend/dist/govuk/all.mjs	3.84 KiB
packages/govuk-frontend/dist/govuk/govuk-frontend-component.mjs	359 B
packages/govuk-frontend/dist/govuk/govuk-frontend.min.css	113.99 KiB
packages/govuk-frontend/dist/govuk/govuk-frontend.min.js	37.89 KiB
packages/govuk-frontend/dist/govuk/i18n.mjs	5.83 KiB

Modules

File	Size
all.mjs	69.04 KiB
components/accordion/accordion.mjs	21.91 KiB
components/button/button.mjs	4.71 KiB
components/character-count/character-count.mjs	22.03 KiB
components/checkboxes/checkboxes.mjs	5.69 KiB
components/error-summary/error-summary.mjs	6.01 KiB
components/exit-this-page/exit-this-page.mjs	16.61 KiB
components/header/header.mjs	3.84 KiB
components/notification-banner/notification-banner.mjs	4.55 KiB
components/radios/radios.mjs	4.68 KiB
components/skip-link/skip-link.mjs	3.74 KiB
components/tabs/tabs.mjs	9.32 KiB

View stats and visualisations on the review app

---

Action run for 32a6181

[colinrotherham]

🎉

[colinrotherham]

Think I'm happy with my final review 🙌

Shall we update the description to add @include govuk-text-colour; has been added where missed too?

Or split that out into another issue? I've not checked if we've caught them all

[owenatgov]

@colinrotherham I've added it to the bottom of the description of this PR. I'm fairly confident we're using govuk-text-colour across our library so I don't think it needs a new issue right now.

[colinrotherham]

Looking rather good 🙌

Can we have an updated file size saving figure? Unless it's bigger 😮

[owenatgov]

@colinrotherham Interestingly, the minified CSS hasn't changed but the map has increased by one kb 😮 I wonder how much of this is impacted by parallel work and rebasing. Not an analysis worth stressing over right now. Merging!

[colinrotherham]

Thanks @owenatgov

We've added more Sass than we've removed I guess? All those source changes needs mapping

They're are only downloaded when developer tools are open so it's fine by me