Remove unnecessary uses of govuk-font #3516
Conversation
✅ You can preview this change here:
To edit notification comments on pull requests, go to your Netlify site configuration. |
owenatgov
force-pushed
the
govuk-font-cleanup
branch
from
b6ff759
to
879c0d8
Compare
| @include govuk-font($size: 24); | ||
| @include govuk-responsive-padding(6); | ||
|
|
||
| display: block; | ||
| margin: 0; | ||
|
|
||
| color: govuk-colour("white"); | ||
| background-color: govuk-colour("blue"); | ||
|
|
||
| text-align: center; |
There was a problem hiding this comment.
Confirming that these styles were duplicated in grid-annotate.scss 👍
owenatgov
force-pushed
the
govuk-font-cleanup
branch
from
879c0d8
to
00ff587
Compare
owenatgov
force-pushed
the
govuk-font-cleanup
branch
2 times, most recently
from
3c8b1cf
to
c2408ea
Compare
There was a problem hiding this comment.
Looks good to me, approving with one comment
The code text looks a bit "thick" now we've lost these two:
-webkit-font-smoothing: antialiased;
-moz-osx-font-smoothing: grayscale;Shall we add it to the pre, code block here?
govuk-design-system/src/stylesheets/main.scss
Lines 117 to 120 in 5a5db22
In case you’re unaware, here are plugins for 2 popular Markdown parsers that do this post-processing:
|
owenatgov
force-pushed
the
govuk-font-cleanup
branch
from
c2408ea
to
592522b
Compare
|
@colinrotherham Resolved! I forgot you could pass a custom |
owenatgov
force-pushed
the
govuk-font-cleanup
branch
from
592522b
to
538c78b
Compare
owenatgov
force-pushed
the
govuk-font-cleanup
branch
from
538c78b
to
ff0c3a2
Compare
What/Why
Removes uses of
govuk-fontwhich are unnecessary, typically because typographic elements such as the font family are cascading from elsewhere and only a font size change may be necessary.Similar to alphagov/govuk-frontend#4267
Notes
Impact on CSS output is fairly minimal. Running
buildagainst this branch vsmainshows that this branch's CSS is1 kilobyte2 kilobyets lighter. I would still argue this is a useful change on the basis that it's ensuring we don't duplicate CSS unnecessarily.Several removes of
govuk-fontare because that element'stypography-commonis being defined byapp-proseand cascading down. In some cases this is convenient but not intentional eg:app-tabs__itemonly needinggovuk-typography-responsivebecauseapp-proseis applying typography to lists, whichapp-tabsare semantically but not necessarily typographically. There have been unofficial chats about replacingapp-prosewith marked post-processing to apply govuk classes to typographic elements in content. If this happens then we would want to putgovuk-fontback on these elements.