-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.8.0 #238
Merged
Merged
v1.8.0 #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add way to encode/decode addresses from binary
) It is a very common use case that js user-devs wish to take a Transaction, convert it to bytes, and then convert it back to a Transaction - either for reading and writing to file, coming in as bytes from a wire, or something else. The js-sdk does support this, but usage is non-obvious and error-prone. So, this commit adds three functions to algosdk: encodeUnsignedTransaction to turn a Transaction into bytes, decodeUnsignedTransaction to take those bytes back to a Transaction, and decodeSignedTransaction to take the output of Transaction.signTxn and turn it into something more usable. (decodeSignedTransaction would also work on the blob member of the object output by algosdk.signTransaction). Review: #218 Resolves: #114 #176
* Update Keccak library to 3.0.1 - Fixes #126 * Add test for htlc keccak hash function Co-authored-by: Jason Paulos <jasonpaulos@users.noreply.github.com>
A bigint is used only when the decoded number cannot fit in to a Number. Resolves: #130
Allow our mocha tests and SDK unit and integration tests to run in browsers.
* Fix browser arguments * Add workaround for firefox testing * Require firefox tests to pass * Simplify dockerfile
* Update tweetnacl * Update superagent
algorotem
approved these changes
Nov 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
encodeAddress
anddecodeAddress
to convert between the binary and text form of Algorand addresses (#216).encodeUnsignedTransaction
,decodeUnsignedTransaction
,decodeSignedTransaction
to convert between binary transactions and transaction objects (#218).rekeyTo
parameter to transaction builder functions (#221).Fixed
assignGroupID
to accept raw transaction objects and instances of theTransaction
class (#236).signTransaction
to accept instances of theTransaction
class (#233).Changed