Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rekey param to make txn functions #221

Merged
merged 1 commit into from
Sep 29, 2020
Merged

Add rekey param to make txn functions #221

merged 1 commit into from
Sep 29, 2020

Conversation

jasonpaulos
Copy link
Contributor

All make transaction functions now take in an optional rekeyTo parameter.

Closes #207

EvanJRichard
EvanJRichard approved these changes Sep 29, 2020
View reviewed changes
Copy link
Contributor

@EvanJRichard EvanJRichard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funny, once upon a time I wanted to implement this feature exactly like this, but at the time we decided to go with Transaction.addRekey instead. Very glad to see this added! 👍

@jasonpaulos jasonpaulos merged commit 07ed42f into develop Sep 29, 2020
@jasonpaulos jasonpaulos deleted the jasonpaulos/rekey-param branch September 29, 2020 18:23
@jasonpaulos jasonpaulos mentioned this pull request Nov 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EvanJRichard EvanJRichard EvanJRichard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add rekeyTo Parameter to Relevant makeTxn Methods
2 participants
@jasonpaulos @EvanJRichard