Github: Update Docker Login Credentials To Use Token #3297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update docker credentials to use PAT, but disable push on merge, due to replacement with docker multiarch jenkins job. Code left to enable easy re-enablement if required.
Haroon-Khel
approved these changes
Dec 14, 2023
sxa
approved these changes
Dec 14, 2023
There was a problem hiding this comment.
We could do a one-off run with push: true to verify that the functionality works as expected, but I'm ok for this to go in regardless since we're switching to using the jenkins job like we do for the other ones.
Ref: https://github.com/docker/login-action/blob/master/README.md#docker-hub (Tokens seem valid in the password field)
Ref: #3296
Also noting that with these changes we should update https://github.com/adoptium/infrastructure/blob/master/FAQ.md#what-about-the-builds-that-use-the-dockerbuild-tag which talks about where the various images are built
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3211
Update docker credentials to use PAT, but disable push on merge, due to replacement with docker multiarch jenkins job. Code left to enable easy re-enablement if required.
The docker push on merge has also been disabled, due to the relocation of the centos6 docker push to the jenkins job as per this PR: #3296
Checklist