Adoptium Centos 6 docker build image in docker hub not updated since last 9 months

[aswinkr77]

The Adoptium Centos 6 docker build image has not gotten the infrastructure updates for the last 9 months. Looks like something is broken.

https://hub.docker.com/r/adoptopenjdk/centos6_build_image

[karianna]

Adoptopenjdk is no longer supported. The images you want are for Eclipse Temurin under the Adoptium project.

[sxa]

@karianna OP is talking about the images we use for building which are created and stored within the adoptopenjdk repository.
They are the ones referred to in the infrastructure FAQ and something within the github action that produces that particular one is not doing the right thing. The same is true of the Alpine3 x64 image which is built in the same place. They're also both showing a green status which means it's not obvious that this is not working properly at present, so thank you to Aswin for picking it up!)

WARNING: No output specified with docker-container driver. Build result will only remain in the build cache. To push result image into registry use --push or to load image into docker use --load

[sxa]

@gdams As you are more familiar with GitHub actions than many of us, are you able to take a look at this?

[steelhead31]

@gdams / @sxa I have a draft PR in #3263, which should work when a PR is merged to docker hub ( this doesn't happen from this process for Alpine, I believe that gets updated via the docker/multiarch process )..   

For Centos6 However it does require authorisation to login to docker hub, and references the variables for these things, but don't believe these are defined.

Any idea how/where we can define these to fix this process, or alternatively, I guess we could keep this action as a check, and move the CentOS6 docker image updater into the multiarch job with the others.

Let me know what your thoughts are.

Thanks!

[steelhead31]

Previous logic did not work on push to master.

[sxa]

Related: We're having issues pushing the riscv64 image too that was added under #3240 ... See slack thread

[steelhead31]

This is still an issue, so continuing to investigate... the logic now works correctly on merge, however the credentials required appear to have changed...

Logging into Docker Hub...
Error: Error response from daemon: Get "https://registry-1.docker.io/v2/": unauthorized: your account must log in with a Personal Access Token (PAT) - learn more at docs.docker.com/go/access-tokens```

[steelhead31]

Given that this will be added to the multiarch job as part of PR #3296, I propose to move the github action to not push to dockerhub, as the alpine one already doesn't push, aligning the centos 6 GHA to not push in addition, and effectively only run as a check seems like a good idea.

[sxa]

Has this not been resolved as a result of the work done last night?

[steelhead31]

Has this not been resolved as a result of the work done last night?

I dont believe so ( though I will check ) the issue with pushing as part of a github action requires a change to the Github credentials... do you think we still need to push to dockerhub as part of the GHA ?, if so I think I'll need to log an EF infra call to have the credentials that are used by Github Actions updated.

[sxa]

Has this not been resolved as a result of the work done last night?

do you think we still need to push to dockerhub as part of the GHA ?

IMHO no (which is why we created the issue to move it ages ago) but others may disagree ...

[steelhead31]

I've pinged @netomi to see if he can update the credentials stored in Github, I'll then pop a PR in to move this to just a simple check, but if the credentials can be updated, it should be simple to switch it back on should it be required.

[Haroon-Khel]

Has this not been resolved as a result of the work done last night?

Yes. Updated last night by the adoptopenjdkuser user (me by cli)

https://hub.docker.com/repository/docker/adoptopenjdk/centos6_build_image/tags?page=1&ordering=last_updated

[Haroon-Khel]

https://ci.adoptium.net/job/centos7_docker_image_updater/420/console kicked off due to merging of #3296

[Haroon-Khel]

The centos6 part of the job succeeded https://ci.adoptium.net/job/centos7_docker_image_updater/420/execution/node/244/log/

[Haroon-Khel]

This can be closed now that the centos6 image can be updated with the automated user