Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix making/building with a custom output path #638

Merged
merged 1 commit into from
Nov 17, 2020
Merged

Fix making/building with a custom output path #638

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion forge/template.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@ const rimraf = promisify(require('rimraf'));
const ncp = promisify(require('ncp'));
const {
emberBuildDir,
emberTestBuildDir
emberTestBuildDir,
packageOutDir
} = require('../lib/utils/build-paths');

async function updateGitIgnore(dir) {
Expand All @@ -19,6 +20,14 @@ async function updateGitIgnore(dir) {
'# Ember build',
`${emberBuildDir}/`,
`${emberTestBuildDir}/`,
// `electron-packager` will automatically ignore the output directory, but
// if someone were to build once without specifying a custom output path,
// and then build with a custom output path, during the second build,
// `electron-packager` would only ignore the custom output path, and not the
// contents of `packageDir`, so it would package up all that previously
// built content in the second packaged application.
'# package/make output directory',
`${packageOutDir}/`,
''
].join('\n'));
}
Expand Down