Fix making/building with a custom output path #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a user were to run `ember electron:package` or `ember electron:make` and then run either command again with a custom output path using `--output-path`, the second application package would end up including all the built assets from the first one, inflating it's size massively. This sorta fixes that -- see comment in code for more info.
RobbieTheWagner
approved these changes
Nov 17, 2020
This was referenced Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user were to run
ember electron:packageorember electron:makeand then run either command again with a custom output path using--output-path, the second application package would end up including all the built assets from the first one, inflating it's size massively. This sorta fixes that -- see comment in code for more info.