Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat Proposal: add progressbar to output #78

Merged
merged 10 commits into from
Mar 28, 2023
Merged

Feat Proposal: add progressbar to output #78

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
1946c83
add progress bar
dimtrovich Mar 8, 2023
e899014
add method to initialize progress via a command
dimtrovich Mar 8, 2023
e9bbcad
update readme to add progress bar usage guide
dimtrovich Mar 8, 2023
b452059
Update src/Output/ProgressBar.php
dimtrovich Mar 20, 2023
fbee526
Update src/Output/ProgressBar.php
dimtrovich Mar 20, 2023
bf32903
Update src/Output/ProgressBar.php
dimtrovich Mar 20, 2023
e2d459f
fix: remove singleton call for progress in command
dimtrovich Mar 27, 2023
fa0b43a
provide setter for option & color the progressbar
dimtrovich Mar 27, 2023
455ac8a
update readme: add progress bar settings
dimtrovich Mar 27, 2023
21f7271
Merge branch 'adhocore:main' into feat-add-progressbar-to-output
dimtrovich Mar 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/Output/ProgressBar.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,9 @@ public function each($items, callable $callback = null)
$items = iterator_to_array($items);
}

$total = count($items);
if (0 === $total = count($items)) {
Copy link
Owner

@adhocore adhocore Mar 20, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooh oops, i think i didn't know how to format code suggestion of github.
the idea was to combine assignment and checks in oneliner

// before
$total = count($items) 
if (!$total) {
    return;
}

// after
if (0 === $total = count($items)) {
    return;
}

return;
}
if (!$total) {
return;
}
Expand Down