Feat Proposal: add progressbar to output #78
Conversation
|
thank you very much. checking soon. this is definitely a missing and good to have stuff. 👍 |
|
|
||
| /** | ||
| * Get the progress bar string, basically: | ||
| * =============> 50% label |
There was a problem hiding this comment.
pretty nice. it would be even better if we can choose progressbar char from a set eg =, ■, ▧, ▨, ▦, ▩ etc with default = :)
which seems as simple as swapping the options['loader']
There was a problem hiding this comment.
that's the idea of the options property. it is planned to put a setter which will modify the pointer, the loader and the color of the progress bar.
we can do something like
$progress->option('loader', '*'); or
$progress->option([ 'loader' => '*', 'pointer' => '>>' ]);
src/Input/Command.php
Outdated
| protected function progress(int $total = null): ProgressBar | ||
| { | ||
| if ($this->_progressBar === null) { | ||
| $this->_progressBar = new ProgressBar(null, $this->writer()); |
There was a problem hiding this comment.
is same progressbar reusable again n again without resetting?
There was a problem hiding this comment.
oh no... i was too focused on minimal resource usage but this way we'll have the same instance of the progressbar every time. thanks very much.
Nevertheless I do not see why someone would venture to call this method several times in the same command
There was a problem hiding this comment.
yea that may not be too normal but not impossible either. maybe in rare cases someone would like to have multiple phases and each phase with different steps that would show progresses.
we can revisit on this later though.
Co-authored-by: Jitendra <2908547+adhocore@users.noreply.github.com>
Co-authored-by: Jitendra <2908547+adhocore@users.noreply.github.com>
Co-authored-by: Jitendra <2908547+adhocore@users.noreply.github.com>
| @@ -166,7 +166,9 @@ public function each($items, callable $callback = null) | |||
| $items = iterator_to_array($items); | |||
| } | |||
|
|
|||
| $total = count($items); | |||
| if (0 === $total = count($items)) { | |||
There was a problem hiding this comment.
ooh oops, i think i didn't know how to format code suggestion of github.
the idea was to combine assignment and checks in oneliner
// before
$total = count($items)
if (!$total) {
return;
}
// after
if (0 === $total = count($items)) {
return;
}
|
hello @dimtrovich , not sure if you lost interest on this pull request? :) |
|
hello @adhocore. sorry for the absence, I had a few small occupations. I added progress bar customization via options and removed singletton behavior from progress bar initialization in commands. however I had difficulty writing tests. it must be said that I do not use phpunit too much but rather kahlan or pest. |
| $line_count = $this->hasLabelLine ? 2 : 1; | ||
|
|
||
| $progress_bar = $this->cursor->up($line_count); | ||
| $progress_bar .= "\r"; |
There was a problem hiding this comment.
is this CR char required? in unix it doesnt seem to be required
(i'm on branch 81-progress-bar trying to write tests)
There was a problem hiding this comment.
I haven't tried with unix but with windows it is essential. when removed, the progress bar goes to a new line on each iteration
Preview => https://ibb.co/W0kMTcz
it would be nice to have a progress bar in the console. At times, a command can execute several tasks simultaneously (for example creation of controllers, models, views, etc.). It would therefore be practical for the person opposite to know the current level of progress of the activity.