Update: Hotgraphic pin number inherits from the icon styles (fixes #282) #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...to inherit from icon instead of body text for consistent pin size
|
🎉 This PR is included in version 9.8.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes adaptlearning/adapt-contrib-hotgraphic#282
Subject of the enhancement
With the current implementation (PR #281), the visited state pin displays larger than the unvisited number. The visited state inherits from
@icon-size(1.5rem) whereas the number pin inherits from@body-size(1rem).In this PR,
.hotgraphic__pin-numberinherits the icon styles for consistent pin number and visited state. See screenshot below.Testing PR
Set
_useNumberedPins: truefor Hotgraphic and select the pins. Set"_isNarrativeOnMobile": false, to review PR on mobile.