Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should item pin number inherit from the icon styles? #282

Closed
kirsty-hames opened this issue Jul 17, 2023 · 1 comment · Fixed by adaptlearning/adapt-contrib-vanilla#455
Closed
Assignees
Labels

Comments

@kirsty-hames
Copy link
Contributor

Subject of the enhancement

With the current implementation (PR #281), the visited state pin displays larger than the unvisited number. The visited state inherits from @icon-size (1.5rem) whereas the number pin inherits from @body-size (1rem).

current_numbers

Should .hotgraphic__pin-number inherit the icon styles instead for consistency of item size? See screenshot below.

numbers_inherit_from_icon
@swashbuck
Copy link
Contributor

we could update the .hotgraphic__pin-number to inherit the icon styles instead.

@kirsty-hames I prefer this option so that the pin circles don't change sizes once visited. I don't have a preference about inheriting from the icon styles or something else, as long as the pin circles don't change sizes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants